Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Rewards panel should say Logged out #23480

Closed
GeetaSarvadnya opened this issue Jun 15, 2022 · 2 comments · Fixed by brave/brave-core#14395
Closed

[Android] Rewards panel should say Logged out #23480

GeetaSarvadnya opened this issue Jun 15, 2022 · 2 comments · Fixed by brave/brave-core#14395
Assignees
Labels

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #21588
Logged out state is not shown in the BR panel when the custodian wallet is disconnected from brave

Steps to reproduce

  1. Clean profile 1.40.x
  2. Enable rewards and connect the existing KYC'd uphold/Gemini/bitFlyer wallet
  3. Get the wallet into a logged-out state
  4. Confirm that the wallet is in the Logged out state on the brave://rewards settings page
  5. Click on the BR panel
  6. Wallet state is NOT in the Logged out state instead it's showing up the Disconnected state

Actual result

Logged out state is not shown in the BR panel when the custodian wallet is disconnected from brave
image

Expected result

Logged-out state should be shown on both rewards settings and BR panel

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Not sure
  • Can you reproduce this issue with the current Play Store Beta version? Not sure
  • Can you reproduce this issue with the current Play Store Nightly version?Not sure

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy Tab A7
  • Android version: version 11

Brave version

1.40.99

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Miyayes @brave/qa-team @deeppandya @emerick

@Miyayes Miyayes changed the title Logged out state is not shown in the BR panel when the custodian wallet is disconnected from brave [Android] Logged out state is not shown in the BR panel when the custodian wallet is disconnected from brave Jun 15, 2022
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 15, 2022
@Miyayes Miyayes changed the title [Android] Logged out state is not shown in the BR panel when the custodian wallet is disconnected from brave [Android] Rewards panel should say Logged out Jul 11, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 29, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 22, 2022

Verified on Samsung Galaxy S 21 & Galaxy Tab S7 using the following build(s):

Brave	1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit) 
Revision	4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS	Android 12; Build/SP1A.210812.016
Uphold - Passed

Scenario:

  1. Enable staging on rewards
  2. Enable rewards
  3. Login in KYC'd custodial account
  4. Check brave://rewards and BR panel for verified state
  5. Check brave://rewards-internals to confirm verified state is displayed in the general tab
  6. Get account into logged-out state by ending the session
  7. Confirm logged out is displayed in brave://rewards and the rewards panel
  8. Check the connection status in rewards-internals
  • Ensured rewards panel and rewards page both show logged out when user is verified but disconnected.
Example Example Example
screenshot-1663856836976 screenshot-1663856849600 screenshot-1663856929359
screenshot-1663858676180 screenshot-1663858730103 screenshot-1663858748607
Gemini - Passed

Scenario:

  1. Enable staging on rewards
  2. Enable rewards
  3. Login in KYC'd custodial account
  4. Check brave://rewards and BR panel for verified state
  5. Check brave://rewards-internals to confirm verified state is displayed in the general tab
  6. Get account into logged-out state by ending the session
  7. Confirm logged out is displayed in brave://rewards and the rewards panel
  8. Check the connection status in rewards-internals
  • Ensured rewards panel and rewards page both show logged out when user is verified but disconnected.
Example Example Example Example
screenshot-1663867835149 screenshot-1663867842541 screenshot-1663867871594 screenshot-1663867881811
bitFlyer - Failed

Logged - #25561

Scenario:

  1. Enable staging on rewards
  2. Enable rewards
  3. Login in KYC'd custodial account
  4. Check brave://rewards and BR panel for verified state
  5. Check brave://rewards-internals to confirm verified state is displayed in the general tab
  6. Get account into logged-out state by ending the session
  7. Confirm logged out is displayed in brave://rewards and the rewards panel
  8. Check the connection status in rewards-internals
Example Example Example
screenshot-1663862047981 screenshot-1663862547207 screenshot-1663862575630

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 13; Build/T1B1.220819.006

@Uni-verse ran through the the following last night but didn't update the issue. So adding my verification notes 👍

Example Example Example
Screenshot_20220922-020516 Screenshot_20220922-025637 Screenshot_20220922-025645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants