Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Brave Ads minimum wait time to improve ad pacing from Griffin #23537

Closed
tmancey opened this issue Jun 17, 2022 · 1 comment · Fixed by brave/brave-core#13846
Closed

Configure Brave Ads minimum wait time to improve ad pacing from Griffin #23537

tmancey opened this issue Jun 17, 2022 · 1 comment · Fixed by brave/brave-core#13846
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.42.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 17, 2022 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#13846

Description

n/a
@tmancey tmancey self-assigned this Jun 17, 2022
@tmancey tmancey mentioned this issue Jun 17, 2022
Merged
25 tasks
@bsclifton bsclifton added this to the 1.42.x - Nightly milestone Jun 17, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#13846

Verified default time is 5 minutes

	Line  329: [13350:13350:0722/144949.181390:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
	Line 1793: [13350:13350:0722/145451.609703:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:

Verified overwriting to 1minutes works:

	Line 271: [14736:14736:0722/150111.616787:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
	Line 646: [14736:14736:0722/150217.310331:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Configure Brave Ads minimum wait time to improve ad pacing from Griffin brave/brave-core
3 participants
@tmancey @bsclifton @btlechowski