Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one more pending request to show a wallet's icon badge #23613

Closed
SergeyZhukovsky opened this issue Jun 22, 2022 · 1 comment · Fixed by brave/brave-core#13935
Closed

Add one more pending request to show a wallet's icon badge #23613

SergeyZhukovsky opened this issue Jun 22, 2022 · 1 comment · Fixed by brave/brave-core#13935
Assignees
@SergeyZhukovsky
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

We miss one more pending request to show badge https://github.com/brave/brave-core/blob/master/android/java/org/chromium/chrome/browser/app/domain/DappsModel.java#L51
The call is mBraveWalletService.getPendingDecryptRequests
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jun 22, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jun 23, 2022
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Jun 23, 2022
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.42.x - Nightly milestone Jun 23, 2022
@SergeyZhukovsky SergeyZhukovsky moved this to Done in Web3 Jun 23, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.42.76 x64 Beta build

Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
23613-ARM.mp4
23613-Tab.mp4

@srirambv srirambv mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Adds a pending decrypt requests to a list of requests to show a badge on Android brave/brave-core
2 participants
@SergeyZhukovsky @srirambv