Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom asset page not loading #23694

Closed
HEagle18 opened this issue Jun 27, 2022 · 1 comment · Fixed by brave/brave-core#13960
Closed

Add custom asset page not loading #23694

HEagle18 opened this issue Jun 27, 2022 · 1 comment · Fixed by brave/brave-core#13960
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

HEagle18 commented Jun 27, 2022

Description

Page not loading for brave://wallet/crypto/portfolio/add-asset
Screenshot 2022-06-27 at 14 19 24

Steps to Reproduce

  1. go on portal
  2. click on view account assets
  3. click add assets
  4. click add custom asset
  5. and wait for brave://wallet/crypto/portfolio/add-asset to load

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

1.42.29 Chromium

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added this to Web3 Jun 27, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Jun 27, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jun 27, 2022
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 27, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 27, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 27, 2022
@Douglashdaniel Douglashdaniel added this to the 1.42.x - Nightly milestone Jun 29, 2022
Repository owner moved this from In Review to Done in Web3 Jun 29, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Linux
  • Verified steps from brave/brave-core#13960
  • Verified visiting brave://wallet/crypto/portfolio/add-asset route directly in a new tab still allows to add asset
  • Verified loading the page route brave://wallet/crypto/portfolio/add-asset directly with wallet locked still allows to add asset after unlocking the wallet
23694-Linux.mp4

Verification passed on

Brave 1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#13960
  • Verified visiting brave://wallet/crypto/portfolio/add-asset route directly in a new tab still allows to add asset
  • Verified loading the page route brave://wallet/crypto/portfolio/add-asset directly with wallet locked still allows to add asset after unlocking the wallet
23694-Windows.mp4

Verification passed on

Brave 1.42.80 Chromium: 104.0.5112.57 (Official Build) (arm64)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#13960
  • Verified visiting brave://wallet/crypto/portfolio/add-asset route directly in a new tab still allows to add asset
  • Verified loading the page route brave://wallet/crypto/portfolio/add-asset directly with wallet locked still allows to add asset after unlocking the wallet
23694-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants