Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command line Brave Ads permission rule - Follow up to 23336 #23708

Closed
tmancey opened this issue Jun 27, 2022 · 1 comment · Fixed by brave/brave-core#13971
Closed

Fix command line Brave Ads permission rule - Follow up to 23336 #23708

tmancey opened this issue Jun 27, 2022 · 1 comment · Fixed by brave/brave-core#13971
Assignees

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 27, 2022

Description

Steps to Reproduce

  1. Try to view an ad by launching the browser from the command-line with --rewards=staging=false to use the production environment

Actual result:

Ad is not served due to --enable-features command-line arg is not supported being shown in the console log

Expected result:

Ad should be served

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@btlechowski
Copy link

Verification passed on

Brave 1.42.65 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

Verified that when --rewards=staging=false flag is used, ads are shown

[9766:9766:0721/115025.488322:VERBOSE1:eligible_notification_ads_v1.cc(38)] Get eligible notification ads:
[9766:9766:0721/115025.490653:VERBOSE1:eligible_notification_ads_v1.cc(161)] Get eligible ads for untargeted segment
[9766:9766:0721/115025.508705:VERBOSE2:priority.h(33)] 1 ads with a priority of 5 in bucket 1
[9766:9766:0721/115025.509022:VERBOSE1:eligible_notification_ads_v1.cc(181)] 1 eligible ads out of 1 ads for untargeted segment
[9766:9766:0721/115025.509422:VERBOSE1:notification_ad_serving.cc(142)] Found 1 eligible ads
[9766:9766:0721/115025.509617:VERBOSE1:notification_ad_serving.cc(251)] Serving notification ad:
  placementId: 8ec6d859-95fa-4275-9479-a92572dff196
  creativeInstanceId: c80153f6-cf22-41c0-8c2c-24c1f9a23c96
  creativeSetId: 58c1dcd9-24a4-4886-bf5d-4235c3074110
  campaignId: 5c00bdb5-a8b2-4290-b51d-96e5db2da195
  advertiserId: 602b6c48-d465-4530-a78f-4488ab88815d
  segment: untargeted
  title: Ledger Nano S
  body: The world’s most popular hardware wallet
  targetUrl: https://shop.ledger.com/products/ledger-nano-s?r=0ba5d7199327

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment