Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave search conversion promotion in omnibox is visible for Non promo-enabled country (Japan) #23815

Closed
MadhaviSeelam opened this issue Jul 1, 2022 · 2 comments
Assignees
Labels
Brave Search bug closed/invalid OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes

Comments

@MadhaviSeelam
Copy link

Description

Steps to Reproduce

  1. Install 1.41.86
  2. set Country or region to Japan in windows settings
  3. launched Brave using --enable-features=BraveSearchOmniboxBanner command-line switch
  4. keep Google as search engine in brave://settings/search
  5. typed brav in the url bar

Actual result:

Search promo banner appeared

image

Expected result:

Promotion should not be enabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS Windows 11 Version 21H2 (Build 22000.739)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@simonhong @rebron
@rebron
Copy link
Collaborator

rebron commented Jul 5, 2022

@MadhaviSeelam This might be invalid. I think country or region is set during installation so changing region post installation won't stick.

@rebron rebron added needs-investigation A bug not 100% confirmed/fixed and removed needs-investigation A bug not 100% confirmed/fixed labels Jul 5, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 15, 2022
@simonhong
Copy link
Member

This issue is not valid anymore because we deleted hardcoded allowed country list.
Promotion will be shown with --enable-features=BraveSearchOmniboxBanner cmd switch always.
Instead, we'll control allowed coutry list via griffin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Brave Search bug closed/invalid OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants