Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Image for Solana on localhost #23821

Closed
srirambv opened this issue Jul 1, 2022 · 2 comments · Fixed by brave/brave-core#14030
Closed

Broken Image for Solana on localhost #23821

srirambv opened this issue Jul 1, 2022 · 2 comments · Fixed by brave/brave-core#14030
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2022

Description

Broken Image for Solana on localhost

Steps to Reproduce

  1. Enable Test nets
  2. Select Localhost
  3. Select Solana, has a broken image

Actual result:

Broken.Solana.Image.on.localhost.mp4

Expected result:

Should show Solana Image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Found while testing #19885 cc: @Douglashdaniel
@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jul 1, 2022
@srirambv srirambv added this to Web3 Jul 1, 2022
@Douglashdaniel
Copy link

I see what the issue is! Selecting Ethereum Local Host should not return Solana as an asset in the send list and vic versa.

@Douglashdaniel Douglashdaniel self-assigned this Jul 1, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jul 1, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Jul 1, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jul 1, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jul 1, 2022
@Douglashdaniel Douglashdaniel added this to the 1.42.x - Nightly milestone Jul 4, 2022
Repository owner moved this from In Review to Done in Web3 Jul 4, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Jul 28, 2022 •
edited
Loading

Verification passed on

Brave 1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Linux
  • Verified steps from issue description
  • Verified switching between Localhost and Solana Localhost networks, doesn't return assets for other Localhost networks
23821-Linux.mp4

Verification passed on

Brave 1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from issue description
  • Verified switching between Localhost and Solana Localhost networks, doesn't return assets for other Localhost networks
23821-Windows.mp4

Verification passed on

Brave 1.42.80 Chromium: 104.0.5112.57 (Official Build) (arm64)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description
  • Verified switching between Localhost and Solana Localhost networks, doesn't return assets for other Localhost networks
23821-macOS.mov

@LaurenWags LaurenWags mentioned this issue Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Prevent Showing Other Localhost Asset brave/brave-core
2 participants
@srirambv @Douglashdaniel