Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2A metrics are not broadcasted [Android] #23922

Closed
Uni-verse opened this issue Jul 7, 2022 · 5 comments
Closed

P2A metrics are not broadcasted [Android] #23922

Uni-verse opened this issue Jul 7, 2022 · 5 comments
Labels
bug features/P3A OS/Android Fixes related to Android browser functionality QA/Yes

Comments

@Uni-verse
Copy link
Contributor

Description

P2A metrics are not being broadcasted on Android platform after enabling rewards and viewing ads.

version 1.41.94 (RC)

Steps to reproduce

  1. Clean install
  2. Connect to Charles Proxy and launch app
  3. Enable rewards
  4. Wait for ads
  5. Monitor Charles for P2A metrics (may have to monitor for 15-20mins to be sure)
  6. Check brave://local-state

Actual result

No metrics broadcasted

Expected result

metrics should be broadcasted to https://p2a.brave.com & https://p2a-json.brave.com

Issue reproduces how often

Easily, follow STR

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone, Tablet - Samsung Galaxy Devices
  • Android version: 12

Brave version

1.41.93/1.41.94

Additional information

@Uni-verse Uni-verse added bug QA/Yes OS/Android Fixes related to Android browser functionality labels Jul 7, 2022
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Jul 7, 2022

CC: @rillian

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 8, 2022

@Uni-verse Please check the play store version. It looks like it's reproducible in GPS as well.

Can you reproduce this issue with the current Play Store version? N/A

Edit the above if issue is reproducible in GPS

@rillian
Copy link

rillian commented Jul 11, 2022

@moritzhaller are P2A reports supposed to be sent from Android? I don't see anything in the code turning it off, but my personal instance with Brave Private Ads enabled doesn't show any P2A keys in brave://local-state either.

@rillian
Copy link

rillian commented Jul 11, 2022

Aha. We don't register the P2A metric names on Android, and indeed brave/brave-core#5949 is marked OS/Desktop only. So I think this was never supposed to work on Android. Sorry for the confusion.

@rillian
Copy link

rillian commented Jul 11, 2022

I've removed the Android label from #22079. Moritz, please reopen if this isn't correct!

@rillian rillian closed this as completed Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug features/P3A OS/Android Fixes related to Android browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants