Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Shields' blocked-count headings between trackers & ads, and scripts #23932

Open
stephendonner opened this issue Jul 8, 2022 · 3 comments
Labels
bug feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA/Test-Plan-Specified QA/Yes

Comments

@stephendonner
Copy link

Description

Inconsistent Shields' blocked-count headings between trackers & ads, and scripts

Steps to Reproduce

  1. install 1.41.3
  2. launch Brave
  3. load https://d3ward.github.io/toolz/adblock.html
  4. click on the Shields icon in the URL bar
  5. click on 99+ link from Block trackers & ads in the resulting dialog
  6. note the 117 Trackers & ads heading
  7. click <-- Shields
  8. toggle Block scripts to ON
  9. click on the #-of-blocked-scripts link
  10. note the 1 Blocked scripts heading

Actual result:

117 Trackers & ads 1 Blocked scripts
Screen Shot 2022-07-08 at 3 47 13 AM Screen Shot 2022-07-08 at 3 47 32 AM

Expected result:

Consistency

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.43.3 Chromium: 103.0.5060.114 (Official Build) nightly (arm64)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS macOS Version 11.6.7 (Build 20G630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rmcfadden3 @aguscruiz @rebron @nullhook

@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop labels Jul 8, 2022
@rmcfadden3
Copy link

@stephendonner — Are you saying that both should include the word "Blocked" and have the same word order? So like "XX tracks & ads blocked" and "XX scripts blocked" ?

@stephendonner
Copy link
Author

@stephendonner — Are you saying that both should include the word "Blocked" and have the same word order? So like "XX tracks & ads blocked" and "XX scripts blocked" ?

That would be one of my primary suggestions, yes.

@rmcfadden3
Copy link

Cool. I like it. Replying here as I caught a typo in my initial suggestion:

"XX trackers & ads blocked"
"XX scripts blocked"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants