Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire Flash settings if it doesn't come for free in C68 #241

Closed
bbondy opened this issue May 29, 2018 · 3 comments
Closed

Expire Flash settings if it doesn't come for free in C68 #241

bbondy opened this issue May 29, 2018 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented May 29, 2018

This should come for free in C68 here:
https://www.chromium.org/flash-roadmap#TOC-Non-Persisted-HTML5-by-Default-Target:-Chrome-68---July-2018-

But if not we should implement it.

@bbondy
Copy link
Member Author

bbondy commented Sep 24, 2018

This came for free from the Chromium 70 upgrade.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 10, 2018

Verified passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Navigated to homestarrunner.com -> received notice in URL bar
    screen shot 2018-10-10 at 5 37 11 pm
  • Clicked 'Run Flash this time'. Clicked 'Click to enable Adobe Flash Player'. Was prompted in URL bar to Allow or Block:
    screen shot 2018-10-10 at 5 38 37 pm
  • Verified both Block and Allow function as expected.
  • Navigated to chrome://settings/content/flash --> Verified setting toggle to 'Ask first' and navigating to flash site did not show Plugin blocked URL bar notice (had to click 'Click to enable Adobe Flash Player' and select block or allow from prompt)
  • Verified flash settings were expired on restart per notice on chrome://settings/content/flash

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

@srirambv
Copy link
Contributor

Linux is blocked on #1562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants