Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads are not blocked for --variations-server-url and --variations-insecure-server-url #24180

Closed
btlechowski opened this issue Jul 21, 2022 · 1 comment

Comments

@btlechowski
Copy link

btlechowski commented Jul 21, 2022

Follow up to: #23336

Steps to Reproduce

  1. Clean profile
  2. Run Brave with:
'--variations-server-url=https://www.google.com'
`--variations-server-url=https://variations.brave.com/seed`
--variations-insecure-server-url=http://localhost
  1. Enable rewards and ads
    1.. Trigger an ad

Actual result:

Ads are shown

Expected result:

Ads are blocked

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

cc @jsecretan @tmancey @brave/qa-team

@tmancey
Copy link
Contributor

tmancey commented Jul 21, 2022

Closing as invalid. I have now updated the test case for brave/brave-core#13695

@tmancey tmancey closed this as completed Jul 21, 2022
@tmancey tmancey self-assigned this Jul 21, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants