Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ETH icon to use Aurora ETH icon #24210

Closed
srirambv opened this issue Jul 22, 2022 · 3 comments · Fixed by brave/brave-core#17692
Closed

Update ETH icon to use Aurora ETH icon #24210

srirambv opened this issue Jul 22, 2022 · 3 comments · Fixed by brave/brave-core#17692
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Aurora uses ETH symbol for native Token.

Steps to reproduce

  1. Upgrade to a build that has Aurora network
  2. Native token uses Eth icon rather than native icon

Actual result

Expected result

Use native icons

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.42.76

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Related desktop issue #24024

@srirambv srirambv added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jul 22, 2022
@srirambv srirambv added this to Web3 Jul 22, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jul 22, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 22, 2022
@srirambv srirambv changed the title Aurora uses ETH symbol for native Token Update ETH icon to use Aurora ETH icon Jul 22, 2022
@Pavneet-Sing
Copy link

This has a dependency on #28561

@Pavneet-Sing
Copy link

Note: This outcome will be changed with #29227

@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.51.87 x64 Beta build

  • Verified steps from issue description and brave/brave-core#17692
  • Verified native asset icon for Aurora is updated to show Aurora Icon.
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
17692-ARM.mp4
17692-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants