Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Site "on-touch" white background on the New Tab Page is misaligned #24676

Closed
nastavoi opened this issue Aug 15, 2022 · 1 comment · Fixed by brave/brave-core#14868
Closed

Comments

@nastavoi
Copy link

nastavoi commented Aug 15, 2022

Description

Top Site "on-touch" white background on the New Tab Page is misaligned (or cut off?)

Steps to reproduce

  1. Open Brave
  2. Open/touch any of the Top Sites on the New Tab Page
  3. Notice that the white/grey background that is appearing when touching the icon is misaligned. I've attached a short video which shows the problem very clearly.

I've also attached a video from Chrome to show how it is supposed to look.

Actual result

Screen_Recording_20220815-190245_Brave.-.Nightly_Trim.v2.mp4

Expected result

Screen_Recording_20220815-201352_Chrome_Trim.mp4

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Samsung S10+
  • Android version: 12

Brave version

Brave Nightly 1.44.40

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No, it's fine on the latest Chrome.

Additional information

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following build(s):

Brave	1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016
  • Verified top sites on-touch white background is aligned
  • Verified webpage is launched upon tapping the top site icon.
fix_top_sites_click.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants