Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different derivation paths for Solana #25111

Closed
yrliou opened this issue Aug 31, 2022 · 1 comment · Fixed by brave/brave-core#15406
Closed

Support different derivation paths for Solana #25111

yrliou opened this issue Aug 31, 2022 · 1 comment · Fixed by brave/brave-core#15406

Comments

@yrliou
Copy link
Member

yrliou commented Aug 31, 2022

Right now we only support 44'/501'/${index}/0', we need to support other options that Ledger Live and Phantom are using, so users can import their accounts from ledger live or phantom using these paths.
See https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1658160838560809 for more details.

Options on Phantom when importing hardware accounts from Ledger:
Screen Shot 2022-08-31 at 12 15 29 PM

Ledger Live: 44'/501'/{index}'

@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2022

Verification passed on

Brave 1.46.87 Chromium: 107.0.5304.91 (Official Build) beta (64-bit)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS Linux
  • Verified steps from brave/brave-core#15406
  • Verified able to import Solana accounts from both Default and Ledger Live
25111.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15406
  • Verified able to import Solana accounts from both Default and Ledger Live
25111.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15406
  • Verified able to import Solana accounts from both Default and Ledger Live
25111.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants