Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "custodial connection unavailable" error modal #25125

Closed
Miyayes opened this issue Sep 1, 2022 · 4 comments · Fixed by brave/brave-core#15627
Closed

Implement "custodial connection unavailable" error modal #25125

Miyayes opened this issue Sep 1, 2022 · 4 comments · Fixed by brave/brave-core#15627
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 1, 2022

Description

Error: Connecting to selected custodian temporarily unavailable

It looks like connecting Brave Rewards to {custodianName} is temporarily unavailable. Please try again later.

You can view service status here.

Server-side PR: brave-intl/bat-go#1574
Documentation: https://github.com/brave-intl/bat-go/pull/1576/files

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 1, 2022
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 7, 2022
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 5, 2022
@Miyayes Miyayes assigned emerick and unassigned mkarolin Oct 5, 2022
@emerick
Copy link
Contributor

emerick commented Oct 21, 2022

@Miyayes Is it important that the custodian name appears in the modal title? We'd have to add new code to handle that, as we only expect to do substitutions in the body of the modal not the title. Not the end of the world if we have to add that, just figured I'd check!

@Miyayes
Copy link
Collaborator Author

Miyayes commented Oct 22, 2022

@emerick I'll edit to remove that. We'll just do substitution in the body.

@LaurenWags
Copy link
Member

LaurenWags commented Dec 19, 2022

Verified with

Brave | 1.47.129 Chromium: 108.0.5359.128 (Official Build) beta (x86_64)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | macOS Version 12.6.2 (Build 21G320)

Verified test plan from brave/brave-core#15627 for:

Uphold - PASSED

Logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/68490aec-31fe-51d8-b4ab-1d23bc140999/claim
> Method: POST
> Content: {"signedLinkingRequest":"eyJib........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/68490aec-31fe-51d8-b4ab-1d23bc140999/claim
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"data":{"validationErrors":null},"message":"Error validating Connecting Brave Rewards to Uphold is temporarily unavailable.  Please try again later"}

Confirmed error message displayed as expected.
Confirmed link navigates to status page as expected.

Example Example Example
Screen Shot 2022-12-19 at 3 03 48 PM Screen Shot 2022-12-19 at 3 06 23 PM Screen Shot 2022-12-19 at 3 07 49 PM
bitFlyer - PASSED

Logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/bitflyer/4d9318d0-6123-5eb9-bf0e-5199857b024e/claim
> Method: POST
> Content: {"linkingInfo":"eyJhb.......
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/bitflyer/4d9318d0-6123-5eb9-bf0e-5199857b024e/claim
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"data":{"validationErrors":null},"message":"Error validating Connecting Brave Rewards to Bitflyer is temporarily unavailable.  Please try again later"}

Confirmed error message displayed as expected.
Confirmed link navigates to status page as expected.

Example Example Example
Screen Shot 2022-12-19 at 3 09 19 PM Screen Shot 2022-12-19 at 3 10 07 PM Screen Shot 2022-12-19 at 3 10 21 PM
Gemini - PASSED

Logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/gemini/374ac816-3b06-5e79-8a22-fca406bceea6/claim
> Method: POST
> Content: {"linking_info":"eyJ0eX...........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/gemini/374ac816-3b06-5e79-8a22-fca406bceea6/claim
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"data":{"validationErrors":null},"message":"Error validating Connecting Brave Rewards to Gemini is temporarily unavailable.  Please try again later"}

Confirmed error message displayed as expected.
Confirmed link navigates to status page as expected.

Example Example Example
Screen Shot 2022-12-19 at 3 11 36 PM Screen Shot 2022-12-19 at 3 11 48 PM Screen Shot 2022-12-19 at 3 12 00 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 4, 2023

Verified on Samsung GS 21 & Samsung Galaxy Tab S7 using version(s):

Brave	1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit) 
Revision	846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS	Android 12; Build/SP1A.210812.016
Brave	1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit) 
Revision	e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS	Android 12; Build/SP2A.220305.013
  • Verified custodial connection unavailable error modal is presented to the user if the custodial linking is dis-abled.
  • Verified user is able to dismiss the modal using the Close button
  • Verified link takes user to Brave status page

Note: Unable to test Gemini linking due to service outages

Uphold BitFlyer
screenshot-1672870360504 screenshot-1672872554281
screenshot-1672944055938 screenshot-1672944667202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants