Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial hot reloading / preview for webui within brave-core #2518

Closed
petemill opened this issue Dec 13, 2018 · 3 comments · Fixed by brave/brave-core#2857
Closed

Initial hot reloading / preview for webui within brave-core #2518

petemill opened this issue Dec 13, 2018 · 3 comments · Fixed by brave/brave-core#2857

Comments

@petemill
Copy link
Member

Overall tracked with #2335

Create a storybook in brave-core to contain src/features from brave-ui

This is not an issue to request hot-reloading in the browser webui's itself, that will require a bit of change to get files served from localhost instead of internal build-produced pak files!

@petemill petemill added this to the 1.x Backlog milestone Dec 13, 2018
@petemill petemill self-assigned this Dec 13, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@cezaraugusto cezaraugusto added this to the 0.69.x - Nightly milestone Jul 10, 2019
@LaurenWags
Copy link
Member

@petemill is manual QA needed for this one? Looks like maybe the first test plan in brave/brave-core#2857 can be executed on a packaged build, but not the others. is that sufficient?

@petemill
Copy link
Member Author

@LaurenWags yes just checking NTP works should be enough, thanks

@LaurenWags
Copy link
Member

LaurenWags commented Aug 29, 2019

Verified passed with

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment