Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a separate form for adding NFTs #25246

Closed
muliswilliam opened this issue Sep 7, 2022 · 1 comment · Fixed by brave/brave-core#15103
Closed

Add a separate form for adding NFTs #25246

muliswilliam opened this issue Sep 7, 2022 · 1 comment · Fixed by brave/brave-core#15103
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@muliswilliam
Copy link

No description provided.

@muliswilliam muliswilliam self-assigned this Sep 7, 2022
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Sep 7, 2022
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Sep 15, 2022
@muliswilliam muliswilliam mentioned this issue Sep 15, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 Sep 30, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 30, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from brave/brave-core#15103
  • Verified a separate tab is shown for adding NFT in the add custom token form
  • Verified able to add NFT only via the NFT form and not via the custom token form

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15103
  • Verified a separate tab is shown for adding NFT in the add custom token form
  • Verified able to add NFT only via the NFT form and not via the custom token form

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15103
  • Verified a separate tab is shown for adding NFT in the add custom token form
  • Verified able to add NFT only via the NFT form and not via the custom token form

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add NFT Form brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam