Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes QR codes and words not displayed for sync #2533

Closed
LaurenWags opened this issue Dec 13, 2018 · 7 comments · Fixed by brave/brave-core#1109 or brave/brave-core#1191
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 13, 2018

Description

First, second, and third attempts to create a sync chain were unsuccessful because QR code and words were not displayed in the UI. I was using a clean profile each time. The fourth time/profile, I was able to see QR code and words.

Similar to #2537

Steps to Reproduce

  1. Clean install of 0.58.12
  2. Go to hamburger menu and choose Brave Sync
  3. Click on Start a new sync chain
  4. Choose Phone/Tablet button or Computer button

Actual result:

No QR code or words. Unsure if something went wrong - there's no error message to user.

screen shot 2018-12-13 at 8 55 37 am

screen shot 2018-12-13 at 9 01 10 am

Expected result:

QR code/words to be displayed as appropriate. OR an error message indicating something is wrong/to try again later/whatever as appropriate.

Reproduces how often:

Unsure

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? unsure

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags
Copy link
Member Author

Seen by @AlexeyBarabash as reported here brave/brave-core#1019 (comment)
And I just experienced it again.

@btlechowski
Copy link

btlechowski commented Dec 13, 2018

Reproduced on Windows 7

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

Reloading the sync page fixes the issue.

@kjozwiak
Copy link
Member

Seems like the issue is intermittent but does happen often enough. I reproduced it on my second clean install. The first once worked correctly but the second install was missing the QR code/chain code.

screen shot 2018-12-13 at 11 03 37 am

screen shot 2018-12-13 at 11 03 47 am

Reproduced using the following:

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

@cezaraugusto cezaraugusto self-assigned this Dec 13, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 14, 2018

Not seeing both QR code and secrete code word on Windows 10 - Bravebeta 0.59.8
image
image

Please note, it was working fine in the morning. I have tested one defect also, all of sudden server stops responding.

@GeetaSarvadnya
Copy link

Issue is still reproducible on Brave beta 0.59.12 Hence reopening the issue.

QR code missing:
image

Code word missing:
image

@GeetaSarvadnya
Copy link

Issue is reproducible on Linux as well - 0.59.12

QR code missing:

image

Code word missing:

image

@kjozwiak
Copy link
Member

kjozwiak commented Jan 8, 2019

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment