Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Switch to Brave Search" prompt #25505

Closed
UjCbFwtBayFM opened this issue Sep 20, 2022 · 5 comments
Closed

Remove "Switch to Brave Search" prompt #25505

UjCbFwtBayFM opened this issue Sep 20, 2022 · 5 comments

Comments

@UjCbFwtBayFM
Copy link

Description

Brave inserts a huge "Switch to Brave Search" overlay prompt every single time I open a new blank tab. Engine is already set to Brave search, which means it does not even check the current engine.

This lack of check aside, this is completely unacceptable behavior on your end to tell users they should use your search engine. Pushing your own products down people's throat is something I could expect from entities like Google or Microsoft, not Brave. REMOVE THAT. You even have the hubris to claim you don't bias or censor results.

Steps to Reproduce

  1. Open a new tab

Actual result:

Prompt appears
ReCutvVrRq

Expected result:

Brave should not suggest I switch my search engine.

Reproduces how often:

Every time I open a new tab.

Brave version (brave://version info)

Brave 1.45.64 Chromium: 106.0.5249.40 (Official Build) nightly (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 10 Version 21H1 (Build 19043.1889)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Sep 20, 2022

@UjCbFwtBayFM just curious, what's your default search engine for Normal windows via brave://settings/search? For example, mine appears as the following via Nightly:

image

Brave inserts a huge "Switch to Brave Search" overlay prompt every single time I open a new blank tab. Engine is already set to Brave search, which means it does not even check the current engine.

If it's set as Brave, you should definitely not be seeing the above. You can also click on the X button which should dismiss the promo/panel. Once dismissed, you shouldn't see it appearing again.

panel

Another quick question would be, what region/language are you using? You can check on Windows via:

  • Settings -> Time & Language -> Language & region

For example, mine looks like the following:

image

Also, we definitely checked and made sure that we wouldn't show users the above promo/panel if Brave was set as the default. So if you're seeing it, it's definitely a bug and not expected behaviour. You can take a look at the checks that were made via the following issues:

@UjCbFwtBayFM
Copy link
Author

You can also click on the X button which should dismiss the promo/panel. Once dismissed, you shouldn't see it appearing again.

It looks like you have trouble understanding the issue here, so I will rephrase my initial statement in simple terms: this screen should NOT appear at all. There is no justification for this kind of despicable way of promoting it. The people who greenlight it are idiots that do not care about UX.

Revert this.

@Brave-Matt
Copy link

@UjCbFwtBayFM,
We're all on the same team here — or at least we're supposed to be. Insults and ultimatums are not going to get your issue resolved any faster or your point across any clearer. Please keep your comments and reports civil and we'll be more than happy to listen and assist you.

Thank you.

@UjCbFwtBayFM
Copy link
Author

@Brave-Matt Remove this feature, or loose supporters and users.

@bsclifton
Copy link
Member

Closing as this experiment (Nightly only) should have concluded a while back and this has been disabled for a while, AFAIK

cc: @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants