Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interstitial UI for ENS L2 offchain contenthash resolution #25515

Closed
supermassive opened this issue Sep 21, 2022 · 1 comment · Fixed by brave/brave-core#15151
Closed

Add interstitial UI for ENS L2 offchain contenthash resolution #25515

supermassive opened this issue Sep 21, 2022 · 1 comment · Fixed by brave/brave-core#15151
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@supermassive
Copy link

ENS L2 was implemented here #22930
Wallet UI here #24990

This issue covers work for asking user consent to use offchain lookup in case of omnibox scenario
@supermassive supermassive self-assigned this Sep 21, 2022
@supermassive supermassive mentioned this issue Sep 21, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 23, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 11, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 12.6 (Build 21G115)

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
@rebron rebron changed the title Interstitial UI for ENS L2 offchain contenthash resolution Add interstitial UI for ENS L2 offchain contenthash resolution Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Offchain lookup interstitial brave/brave-core
4 participants
@supermassive @srirambv @LaurenWags @brave-builds