Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market tab in Wallet is showing the wrong base currency #25668

Closed
urbenlegend opened this issue Sep 28, 2022 · 2 comments · Fixed by brave/brave-core#15402
Closed

Market tab in Wallet is showing the wrong base currency #25668

urbenlegend opened this issue Sep 28, 2022 · 2 comments · Fixed by brave/brave-core#15402
Assignees
Labels

Comments

@urbenlegend
Copy link

Description

The Market tab in Wallet always shows USD. It does not follow the default base currency set in brave://settings/wallet.

Steps to Reproduce

  1. Go to brave://settings/wallet and change the default base currency to something other than USD
  2. Go to brave://wallet/crypto/market
  3. Notice that the prices are still listed in USD

Actual result:

Market tab shows prices in USD even when you set the default base currency setting to something other than USD

Expected result:

Market tab should show prices in the base currency that the user has set

Reproduces how often:

Every time

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@rebron rebron added this to Web3 Oct 3, 2022
@rebron rebron added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 3, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 7, 2022
@jamesmudgett
Copy link

@muliswilliam

@muliswilliam muliswilliam self-assigned this Oct 10, 2022
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Oct 10, 2022
Repository owner moved this from In Progress to Done in Web3 Oct 11, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 11, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from issue description & brave/brave-core#15402
  • Verified Market tab uses the selected based currency
  • Verified token details page from Market tab still shows the currently set default currency
25668.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description & brave/brave-core#15402
  • Verified Market tab uses the selected based currency
  • Verified token details page from Market tab still shows the currently set default currency
25668.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description & brave/brave-core#15402
  • Verified Market tab uses the selected based currency
  • Verified token details page from Market tab still shows the currently set default currency
25668.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants