Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat currency selection not working on Fund Wallet screen #25686

Closed
josheleonard opened this issue Sep 28, 2022 · 1 comment · Fixed by brave/brave-core#15265
Closed

Fiat currency selection not working on Fund Wallet screen #25686

josheleonard opened this issue Sep 28, 2022 · 1 comment · Fixed by brave/brave-core#15265

Comments

@josheleonard
Copy link

Description

The fiat currency selector that is shown on the fund wallet screen does not show fiat options when clicked

Steps to Reproduce

  1. Create a wallet
  2. navigate to brave://wallet/crypto/fund-wallet
  3. click the fiat symbol "$"

Actual result:

Nothing happens after clicking the fiat symbol

Expected result:

A searchable list of fiat currencies should appear

Reproduces how often:

Easy

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2022

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from brave/brave-core#15265
  • Verified currency selection dropdown is clickable
  • Verified able to search for availbale Fiat options
  • Verified changing Fiat currency automatically updates the token value as well
25686.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15265
  • Verified currency selection dropdown is clickable
  • Verified able to search for availbale Fiat options
  • Verified changing Fiat currency automatically updates the token value as well
25686.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15265
  • Verified currency selection dropdown is clickable
  • Verified able to search for availbale Fiat options
  • Verified changing Fiat currency automatically updates the token value as well
25686.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants