Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending to another address using QR code is not working #25731

Closed
HEagle18 opened this issue Sep 30, 2022 · 2 comments · Fixed by brave/brave-core#15319
Closed

Sending to another address using QR code is not working #25731

HEagle18 opened this issue Sep 30, 2022 · 2 comments · Fixed by brave/brave-core#15319
Assignees
@Pavneet-Sing
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@HEagle18
Copy link

Description

Tried this on metamask and gamestop wallet. When I tried to send to to the QR code, it returned with text 'ethereum' before the address

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@HEagle18 HEagle18 added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Sep 30, 2022
@HEagle18 HEagle18 added this to Web3 Sep 30, 2022
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 30, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Sep 30, 2022
@jamesmudgett
Copy link

Remove "Ethereum:" from the address data in qr code

@Pavneet-Sing Pavneet-Sing mentioned this issue Oct 3, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing self-assigned this Oct 3, 2022
Repository owner moved this from Backlog to Done in Web3 Oct 3, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 3, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.46.70 x64 Beta build

  • Verified scanning QR code works fine
  • Verified for both Ethereum and Solana accounts
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
25731-ARM.mp4
25731-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

fix: Wallet qr address and link color per theme brave/brave-core
5 participants
@jamesmudgett @Pavneet-Sing @HEagle18 @srirambv @brave-builds