Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Wallet moves line position to end when editing #25774

Closed
Douglashdaniel opened this issue Oct 3, 2022 · 1 comment · Fixed by brave/brave-core#15334
Closed

Restore Wallet moves line position to end when editing #25774

Douglashdaniel opened this issue Oct 3, 2022 · 1 comment · Fixed by brave/brave-core#15334
Assignees
@josheleonard
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@Douglashdaniel
Copy link

Description

When restoring a Wallet during onboarding, if you try to edit any of the phrase it will move your line position to the end of the phrase.

Screen.Recording.2022-10-03.at.9.47.11.AM.mov
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Oct 3, 2022
@josheleonard josheleonard self-assigned this Oct 3, 2022
@josheleonard josheleonard moved this to In Progress in Web3 Oct 3, 2022
@josheleonard josheleonard mentioned this issue Oct 3, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 Oct 4, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 4, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from issue description
  • Verified editing seed words doesn't move cursors position
25774.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description
  • Verified editing seed words doesn't move cursors position
25774.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description
  • Verified editing seed words doesn't move cursors position
25774.mov

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Fix restore wallet moves line position to end when editing brave/brave-core
4 participants
@srirambv @josheleonard @Douglashdaniel @brave-builds