Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT images not loading in panel #25784

Closed
josheleonard opened this issue Oct 3, 2022 · 1 comment · Fixed by brave/brave-core#15340
Closed

NFT images not loading in panel #25784

josheleonard opened this issue Oct 3, 2022 · 1 comment · Fixed by brave/brave-core#15340

Comments

@josheleonard
Copy link

josheleonard commented Oct 3, 2022

Description

NFT asset images are not loaded correctly within the Panel UI.
Console logs the following:

[ERROR:html_media_element.cc(4791)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}

[ERROR:CONSOLE(66763)] "Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('chrome-untrusted://nft-display') does not match the recipient window's origin ('null').", source: chrome://wallet-panel.top-chrome/brave_wallet_panel.bundle.js (66763)

Steps to Reproduce

  1. Create a Wallet
  2. Add an NFT asset
  3. Unlock panel
  4. click "View account assets"

Actual result:

NFT images are not loaded
Screen Shot 2022-10-03 at 11 33 44 AM

Expected result:

NFT images should be displayed

Reproduces how often:

Easy

@josheleonard josheleonard added this to Web3 Oct 3, 2022
@muliswilliam muliswilliam self-assigned this Oct 3, 2022
@rebron rebron added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 3, 2022
@muliswilliam muliswilliam moved this to Backlog in Web3 Oct 4, 2022
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Oct 4, 2022
Repository owner moved this from In Progress to Done in Web3 Oct 5, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 5, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from issue description & brave/brave-core#15340
  • Verified panel shows NFT image
  • Verified panel shows NFT gif images as well
  • Encountered #26388
25784.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description & brave/brave-core#15340
  • Verified panel shows NFT image
  • Verified panel shows NFT gif images as well
25784.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 12.6 (Build 21G115)
  • Verified steps from issue description & brave/brave-core#15340
  • Verified panel shows NFT image
  • Verified panel shows NFT gif images as well
25784.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants