Hidden bookmarks bar flashes when opening new tab

[georapbox]

Description

If bookmarks bar is always hidden, when opening a new tab, the bookmarks bar appears for few milliseconds and then disappears again. The issue happens only if there are bookmarks saved.

Steps to Reproduce

1. Disable "Show bookmarks bar" under "Settings > Appearance > Show bookmarks bar"
   

2. Open a new tab

Actual result:

Bookmarks bar appears for a few milliseconds and then disappears again, causing an annoying flash effect.

Screen.Recording.2022-10-06.at.10.22.23.AM.mov

Expected result:

The bookmarks bar should not flash.

Reproduces how often:

Always when the bookmarks bar is set to be always hidden.

Brave version (brave://version info)

Brave: 1.44.105 Chromium: 106.0.5249.91 (Official Build) (x86_64)
Revision: fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS: macOS Version 10.15.7 (Build 19H1323)

Version/Channel Information:

Can you reproduce this issue with the current release?
Yes

Can you reproduce this issue with the beta channel?
Yes

Can you reproduce this issue with the nightly channel?
Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
No

Does the issue resolve itself when disabling Brave Rewards?
No

Is the issue reproducible on the latest version of Chrome?
No, in Chrome bookmarks bar is always displayed in new tab page.

Miscellaneous Information:

The issue might be caused due to the fact that Chromium always displays the bookmarks bar when opening a new tab page. Therefore, there might be a case that Brave delays to hide the bar, hence the flash effect.

[rebron]

cc: @spylogsster

[spylogsster]

cannot reproduce in Nightly @georapbox can you try on your side? thanks

[georapbox]

Hi,

Just tried that with latest Nightly and still happening on my side.

Brave: 1.47.2 Chromium: 107.0.5304.36 (Official Build) nightly (x86_64)
Revision: 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS: macOS Version 10.15.7 (Build 19H1323)

Screen.Recording.2022-10-21.at.9.48.38.AM.mov

[georapbox]

Just found a related question in reddit if that helps...

https://www.reddit.com/r/brave_browser/comments/yssvml/bookmark_is_hidden_on_new_tab_and_other_tabs_but/

[manikandancode]

On a low-end system, it stays for more than 3 sec

[void4]

I have a ton of bookmarks, and I believe this is slowing my browser down. Would be nice if this were solved

[LaurenWags]

fwiw, @rebron this is still reproducible with 1.61.x on macOS

@krwow this issue has a priority, so it's in the queue, but will mention it in our next triage meeting.

[simonhong]

Fixing now.

[stephendonner]

Verified PASSED using

Brave | 1.64.48 Chromium: 121.0.6167.139 (Official Build) nightly (x86_64)
-- | --
Revision | 741f7ee622bdfde5e10e3beda02288f3c056287e
OS | macOS Version 11.7.10 (Build 20G1427)

Followed inline steps to reproduce.

Confirmed with bookmarks populated, but with Show Bookmarks set to Never, there's no longer flickering when opening the new-tab page

screencast	brave://settings

[brad86m]

This is still happening.

[LaurenWags]

Hi @brad86m - this fix is only on Nightly and Beta right now and will be coming to the Release channel next week with version 1.64.x. If you're still seeing this issue on Nightly or Beta please do log an issue with additional information (your OS, etc). Thanks!