Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portfolio: Add hover feedback on the asset list #25848

Closed
kleantzogu opened this issue Oct 6, 2022 · 2 comments · Fixed by brave/brave-core#15466
Closed

Portfolio: Add hover feedback on the asset list #25848

kleantzogu opened this issue Oct 6, 2022 · 2 comments · Fixed by brave/brave-core#15466
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@kleantzogu
Copy link

No description provided.

@rebron rebron added OS/Desktop feature/web3/wallet Integrating Ethereum+ wallet support labels Oct 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 7, 2022
@kleantzogu
Copy link
Author

Figma: https://www.figma.com/file/CPUOGNxaQXHheUMoucwQFN/Portfolio?node-id=982%3A35156

Image

@Douglashdaniel Douglashdaniel mentioned this issue Oct 14, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from Backlog to In Review in Web3 Oct 14, 2022
Repository owner moved this from In Review to Done in Web3 Oct 14, 2022
@Douglashdaniel Douglashdaniel added this to the 1.46.x - Nightly milestone Oct 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from brave/brave-core#15466
  • Verified hover state is shown on asset list
  • Verified on both dark and light theme
25848.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15466
  • Verified hover state is shown on asset list
  • Verified on both dark and light theme
25848.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15466
  • Verified hover state is shown on asset list
  • Verified on both dark and light theme
25848.mov

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add Hover Background to Asset List brave/brave-core
4 participants
@kleantzogu @rebron @srirambv @Douglashdaniel