Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Restore" tab from Manage Brave Rewards section #26338

Closed
Miyayes opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#15738
Closed

Remove "Restore" tab from Manage Brave Rewards section #26338

Miyayes opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#15738
Assignees
@emerick
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 28, 2022 •
edited
Loading

Description

Remove "Restore" tab from Manage Brave Rewards section.

image

cc: @szilardszaloki
@Miyayes Miyayes added feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 28, 2022
@emerick
Copy link
Contributor

emerick commented Oct 28, 2022

@Miyayes Just confirming that the View QR Code feature (bottom of the Restore tab) goes away too?

@Miyayes
Copy link
Collaborator Author

Miyayes commented Oct 31, 2022

@emerick Yes, that also goes away.

@emerick emerick mentioned this issue Nov 1, 2022
Merged
25 tasks
@emerick emerick added this to the 1.47.x - Nightly milestone Nov 2, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 5, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2022 •
edited
Loading

Verified with

Brave | 1.47.114 Chromium: 108.0.5359.94 (Official Build) beta (x86_64)
-- | --
Revision | 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS | macOS Version 12.6.1 (Build 21G217)

Verified test plan from brave/brave-core#15738.
Confirmed no "Restore" tab on the "Manage Brave Rewards" popup.

Example Example
1 2

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 5, 2022
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy GS 21 & Samsung Galaxy Tab S7 on the following version(s):

Brave	1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit) 
Revision	846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS	Android 12; Build/SP1A.210812.016
  • Verified user is able to join brave rewards
  • Verified brave://rewards page has not regressed
Example Example
screenshot-1672855552647 screenshot-1672855667255

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
This was referenced Jan 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Restore tab from Manage Brave Rewards dialog brave/brave-core
4 participants
@emerick @Miyayes @Uni-verse @LaurenWags