Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFTs added before image support do not show icons on portfolio list and NFT tab #26343

Closed
muliswilliam opened this issue Oct 28, 2022 · 1 comment · Fixed by brave/brave-core#15730
Closed

NFTs added before image support do not show icons on portfolio list and NFT tab #26343

muliswilliam opened this issue Oct 28, 2022 · 1 comment · Fixed by brave/brave-core#15730
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Oct 28, 2022 •
edited
Loading

Portfolio - Icons not loading

Image

NFT Tab - Showing placeholder image

Image
@muliswilliam muliswilliam self-assigned this Oct 28, 2022
@jamesmudgett jamesmudgett moved this to In Progress in Web3 Oct 28, 2022
@muliswilliam muliswilliam mentioned this issue Nov 1, 2022
Merged
25 tasks
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Nov 1, 2022
Repository owner moved this from In Review to Done in Web3 Nov 4, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 4, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Linux
  • Verified steps from brave/brave-core#15730
  • Verified NFT image is shown on details screen and in portfolio screen

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15730
  • Verified NFT image is shown on details screen and in portfolio screen

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (arm64)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15730
  • Verified NFT image is shown on details screen and in portfolio screen

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Update NFT logo field for NFTs added before NFT Metadata support brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam