We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave is pinned to the taskbar when brave is NOT pinned explicitly via the first run dialog
This issue is not reproducible 100% but I have seen the issue 3 to 4 times in 3 days while dog fooding the beta build (1.46.x)
STR 1:
May be later
STR2:
x
Skip welcome tour
Brave should not be pinned to the taskbar when brave is NOT pinned explicitly via the first run dialog
Intermittent
cc: @brave/qa-team @simonhong @rebron
The text was updated successfully, but these errors were encountered:
Pin to taskbar option
@GeetaSarvadnya I found why you're experiencing this on beta. With this https://chromium-review.googlesource.com/c/chromium/src/+/3858031, upstream started to pin to taskbar by installer - constexpr int kBetaRolloutPercentage = 10; Maybe 10% of Win10+ users will get pinned with this change.
constexpr int kBetaRolloutPercentage = 10;
Win10+
bool ShouldPinChromeToTaskbar() { if (base::win::GetVersion() < base::win::Version::WIN10) return true; switch (install_static::GetChromeChannel()) { case version_info::Channel::BETA: { // Increase kBetaRolloutPercentage to roll out to beta channel. constexpr int kBetaRolloutPercentage = 10; return base::RandInt(0, 99) < kBetaRolloutPercentage; } case version_info::Channel::STABLE: { constexpr int kStableRolloutPercentage = 0; return base::RandInt(0, 99) < kStableRolloutPercentage; } default: return false; } }
And it seems upstream already changed it to 100% by https://chromium-review.googlesource.com/c/chromium/src/+/3858031 But it's not yet arrived to our master. Then maybe we don't need Pin to taskbar checkbox in first run dialog on Windows. cc @rebron
Pin to taskbar
Sorry, something went wrong.
Ok, I'll remove checkbox when upstream set 100% asstable rollout percentage.
@GeetaSarvadnya - Closing this issue since first run dialog is disabled via #27225. And I filed a follow up for the same issue #27499 cc: @rebron @simonhong
simonhong
No branches or pull requests
Description
Brave is pinned to the taskbar when brave is NOT pinned explicitly via the first run dialog
This issue is not reproducible 100% but I have seen the issue 3 to 4 times in 3 days while dog fooding the beta build (1.46.x)
Steps to Reproduce
STR 1:
May be later
in first run dialogSTR2:
x
in first run dialogSkip welcome tour
linkActual result:
Brave is pinned to the taskbar when brave is NOT pinned explicitly via the first run dialog
Expected result:
Brave should not be pinned to the taskbar when brave is NOT pinned explicitly via the first run dialog
Reproduces how often:
Intermittent
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @simonhong @rebron
The text was updated successfully, but these errors were encountered: