Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test run on macOS (arm64) for Tor 0.4.7.10 - Release #2 #26554

Closed
18 tasks done
kjozwiak opened this issue Nov 4, 2022 · 5 comments
Closed
18 tasks done

Manual test run on macOS (arm64) for Tor 0.4.7.10 - Release #2 #26554

kjozwiak opened this issue Nov 4, 2022 · 5 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

Monterey 12.x

Tor Client Updater

  • For development go-update-server. Run brave-browser with --user-data-dir=component-dev --use-dev-goupdater-url (These flags are only available in v1.7.x). Once the crx is pushed to production run without these flags.
  • Navigate to brave://components and verify Tor Client Updater (OS) is updated successfully.
  • Open New Private Window with Tor and confirm that it starts without any errors.
    • Navigate to check.torproject.org and verify that tor is working successfully.
    • Navigate to brave.com and http://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/ to check if the sites work correctly.
  • Load brave.com and mail.protonmail.com in a regular Window/Tab and ensure that clicking the Tor button in the URL bar correctly launches a Tor window and opens the appropriate .onion website.

MacOS

  • Navigate to /Users/<user>/Library/Application Support/BraveSoftware/Brave-Browser-<channel>/cldoidikboihgcjfkhdeidbpclkineef/<version>
  • Run codesign -vvvv tor-<version-tor>-darwin-brave-<version-brave> to confirm codesign is valid
  • For MacOS Catalina (10.15+) - Run spctl -a -vv -t install tor-<version-tor>-darwin-brave-<version-brave> to verify that the binary is notarized.

Big Sur 11.x

Tor Client Updater

  • For development go-update-server. Run brave-browser with --user-data-dir=component-dev --use-dev-goupdater-url (These flags are only available in v1.7.x). Once the crx is pushed to production run without these flags.
  • Navigate to brave://components and verify Tor Client Updater (OS) is updated successfully.
  • Open New Private Window with Tor and confirm that it starts without any errors.
    • Navigate to check.torproject.org and verify that tor is working successfully.
    • Navigate to brave.com and http://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/ to check if the sites work correctly.
  • Load brave.com and mail.protonmail.com in a regular Window/Tab and ensure that clicking the Tor button in the URL bar correctly launches a Tor window and opens the appropriate .onion website.

MacOS

  • Navigate to /Users/<user>/Library/Application Support/BraveSoftware/Brave-Browser-<channel>/cldoidikboihgcjfkhdeidbpclkineef/<version>
  • Run codesign -vvvv tor-<version-tor>-darwin-brave-<version-brave> to confirm codesign is valid
  • For MacOS Catalina (10.15+) - Run spctl -a -vv -t install tor-<version-tor>-darwin-brave-<version-brave> to verify that the binary is notarized.
@kjozwiak
Copy link
Member Author

kjozwiak commented Nov 4, 2022

Quick note: The Tor daemon itself was not updated and is still on 0.4.7.10. However, the following did get upgraded:

  • OpenSSL - 1.1.1q -> 1.1.1s
  • Zlib - 1.2.12 -> 1.2.13

@stephendonner stephendonner self-assigned this Nov 4, 2022
@stephendonner
Copy link

stephendonner commented Nov 4, 2022

Big Sur - PASSED

Verified PASSED using

Brave 1.45.118 Chromium: 107.0.5304.91 (Official Build) (arm64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Confirmed that the correct Tor component was being downloaded via --use-dev-goupdater-url:

Screen Shot 2022-11-04 at 4 15 14 PM

Confirmed that the Tor component was started when launching Tor and ensured Tor 0.4.7.10 was being used:

Nov 04 15:14:18.333 [notice] Tor 0.4.7.10 running on Darwin with Libevent 2.1.12-stable, OpenSSL 1.1.1s, Zlib 1.2.13, Liblzma N/A, Libzstd N/A and Unknown N/A as libc.

stephendonner@Stephens-MacBook-Pro-3 1.0.52 % codesign -vvvv tor-0.4.7.10-darwin-brave-1 tor-0.4.7.10-darwin-brave-1: valid on disk tor-0.4.7.10-darwin-brave-1: satisfies its Designated Requirement stephendonner@Stephens-MacBook-Pro-3 1.0.52 % spctl -a -vv -t install tor-0.4.7.10-darwin-brave-1 tor-0.4.7.10-darwin-brave-1: accepted source=Notarized Developer ID origin=Developer ID Application: Brave Software, Inc. (KL8N8XSYF4)

Confirmed that you can open the following domains in a Tor window without issues:

brave.com
duckduckgo.com
https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/
check.torproject.org (ensured that hard-refreshing gets a new circuit/IP)

Confirmed the following sites opened via “Open in Tor” button from normal window and navigated to their .onion URL in a Tor window:

brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
https://account.proton.me/login --> https://account.protonmailrmez3lotccipshtkleegetolb73fuirgj7r4o4vfu7ozyd.onion/
nytimes.com --> https://www.nytimesn7cgmftshazwhfgzm37qxb44r64ytbb2dj3x62d2lljsciiyd.onion/

@stephendonner
Copy link

@kjozwiak @LaurenWags leaving open still, since I think we want to also do Monterey?

@LaurenWags
Copy link
Member

yeah, we usually do. I'll add a section for it.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 7, 2022

Verified for the below:

macOS 12.6.1 Monterey arm64 - PASSED

Verified on macOS 12.6.1 arm64 using the following build:

Brave	1.45.118 Chromium: 107.0.5304.91 (Official Build) (arm64)
Revision	3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS	macOS Version 12.6.1 (Build 21G217)

Confirmed that the correct Tor component was being downloaded via --use-dev-goupdater-url:

M1

Confirmed that the Tor component was started when launching Tor and ensured Tor 0.4.7.10 was being used.
Confirmed that OpenSSL version is 1.1.1s per #26553 (comment).
Confirmed the Zlib version is 1.2.13 per #26553 (comment).

Nov 07 13:20:16.262 [notice] Tor 0.4.7.10 running on Darwin with Libevent 2.1.12-stable, OpenSSL 1.1.1s, Zlib 1.2.13, Liblzma N/A, Libzstd N/A and Unknown N/A as libc.

Confirmed that you can open the following domains in a Tor window without issues:

Confirmed the following sites opened via “Open in Tor” button from normal window and navigated to .onion URL in a Tor window:

Confirmed that codesign is valid:

laurenwags@Laurens-M1 1.0.55 % codesign -vvvv tor-0.4.7.10-darwin-brave-2
tor-0.4.7.10-darwin-brave-2: valid on disk
tor-0.4.7.10-darwin-brave-2: satisfies its Designated Requirement

Confirmed that the binary is notarized:

laurenwags@Laurens-M1 1.0.55 % spctl -a -vv -t install tor-0.4.7.10-darwin-brave-2
tor-0.4.7.10-darwin-brave-2: accepted
source=Notarized Developer ID
origin=Developer ID Application: Brave Software, Inc. (KL8N8XSYF4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment