Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ordinal number from text to number + text #26591

Closed
josheleonard opened this issue Nov 7, 2022 · 1 comment · Fixed by brave/brave-core#15831
Closed

Change ordinal number from text to number + text #26591

josheleonard opened this issue Nov 7, 2022 · 1 comment · Fixed by brave/brave-core#15831
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@josheleonard
Copy link

Description

During recovery phrase backup, update the badges of selected words to display ordinal number as a number&text(11th) instead of text(Eleventh)
@josheleonard josheleonard added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 7, 2022
@josheleonard josheleonard self-assigned this Nov 7, 2022
@josheleonard josheleonard added this to Web3 Nov 7, 2022
@josheleonard josheleonard mentioned this issue Nov 7, 2022
Merged
25 tasks
@josheleonard josheleonard moved this to Done in Web3 Nov 8, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 8, 2022
@srirambv
Copy link
Contributor

Verified as part of #26399 (comment). Verified selected words show number&text (11th) instead of text (Eleventh)

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

fix: wallet backup verify words badge ordinals format brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds