Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pravda.com.ua feeds not found by search auto-discovery #26676

Closed
stephendonner opened this issue Nov 10, 2022 · 3 comments · Fixed by brave/brave-core#15961
Closed

pravda.com.ua feeds not found by search auto-discovery #26676

stephendonner opened this issue Nov 10, 2022 · 3 comments · Fixed by brave/brave-core#15961

Comments

@stephendonner
Copy link

Description

pravda.com.ua feeds not found by search auto-discovery

NOTE: This is essentially #26550, which we missed when verifying for uplifts. Instead, it looks like I verified feed auto-discovery within search only worked with planet.mozilla.org, rather than this, which was originally filed. Apologies.

Steps to Reproduce

  1. install 1.47.55
  2. launch Brave
  3. set brave://flags/#brave-news-v2 and brave://flags/#brave-news-subscribe-button to Enabled`
  4. click Relaunch
  5. open a new-tab page
  6. click on Customize
  7. click on Brave News
  8. click on Turn on Brave News
  9. under Discover, enter https://www.pravda.com.ua/eng/
  10. when Sources pops up with Get feeds from... click it
  11. wait

Actual result:

Screenshot 2022-11-10 at 15 16 37

Expected result:

I believe it should find these feeds:

<link rel="alternate" type="application/rss+xml" title="УП - Новини" href="https://www.pravda.com.ua/rss/view_news/"/>
<link rel="alternate" type="application/rss+xml" title="УП - Тільки найважливіші новини" href="https://www.pravda.com.ua/rss/view_mainnews/"/>
<link rel="alternate" type="application/rss+xml" title="УП - Публікації" href="https://www.pravda.com.ua/rss/view_pubs/"/>
<link rel="alternate" type="application/rss+xml" title="УП - Загальна стрічка всіх матеріалів (рос)" href="https://www.pravda.com.ua/rus/rss/"/>
<link rel="alternate" type="application/rss+xml" title="УП - Новини (рос)" href="https://www.pravda.com.ua/rus/rss/view_news/"/>
<link rel="alternate" type="application/rss+xml" title="УП - Тільки найважливіші новини (рос)" href="https://www.pravda.com.ua/rus/rss/view_mainnews/"/>
<link rel="alternate" type="application/rss+xml" title="УП - Публікації (рос)" href="https://www.pravda.com.ua/rus/rss/view_pubs/"/>

They show up in the URL bar, under Manage Subscriptions

view-source URL bar
Screenshot 2022-11-10 at 15 17 44 Screenshot 2022-11-10 at 15 06 12

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.55 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 13.1 (Build 22C5044e)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @petemill @MadhaviSeelam @mattmcalister

@fallaciousreasoning
Copy link

Okay, this is broken for a different reason to #26550 - here the HTML was being returned with a non-UTF8 encoding, and we were completely failing to parse it. Fortunately the fix is simple enough: Parse the HTML doc with the appropriate encoding.

@LaurenWags
Copy link
Member

Requires 1.46.122 or higher to test.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.122 Chromium: 108.0.5359.48 (Official Build) beta (x86_64)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.122
  2. launched Brave
  3. set brave://flags/#brave-news-v2 and brave://flags/#brave-news-subscribe-button to Enabled
  4. clicked Relaunch
  5. opened a new-tab page
  6. clicked on Customize
  7. clicked on Brave News
  8. clicked on Turn on Brave News
  9. under Discover, entered https://www.pravda.com.ua/eng/
  10. clicked on Get feeds from...
  11. waited

Confirmed I could search for, find, and subscribe to (Follow) those sources, which showed up in my Brave News feed

example example example example
Screen Shot 2022-11-21 at 9 10 18 PM Screen Shot 2022-11-21 at 9 10 25 PM Screen Shot 2022-11-21 at 9 10 41 PM Screen Shot 2022-11-21 at 9 11 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants