Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazil, Mexico, and Spain to Brave News "Default Enabled" list #26678

Closed
petemill opened this issue Nov 11, 2022 · 5 comments · Fixed by brave/brave-core#15877
Closed

Add Brazil, Mexico, and Spain to Brave News "Default Enabled" list #26678

petemill opened this issue Nov 11, 2022 · 5 comments · Fixed by brave/brave-core#15877

Comments

@petemill
Copy link
Member

If the user has the following OS language and region set, then Brave News should start to show by default (new and existing users, unless the user has enabled and disabled Brave News from NTP).

es_ES
es_MX
pt_BR

The user should see content from that region.

@stephendonner
Copy link

stephendonner commented Nov 11, 2022

@petemill not ja-JP/ja/ja_JP, as well?

@petemill
Copy link
Member Author

All ja and en users are already default-enabled.

@stephendonner
Copy link

All ja and en users are already default-enabled.

Yep, sorry - read the patch and saw that it's already in, as you say 👍

@kjozwiak
Copy link
Member

The above requires 1.46.107 or higher for 1.46.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 14, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 14, 2022

Verification PASSED using

Brave | 1.46.109 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
-- | --
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Test Case 1: Region: es_ES - PASSED

Pre-requisite:

  • Set OS language - Espanol (Espana)
  • Set region: Spain
OS region
image image

Case 1: Existing User - PASSED

  1. Install 1.46.99
  2. launch Brave
  3. clicked on Personalizar
  4. clicked Brave News
  5. Enabled Mostrar Brave News in the Personalizar el Dashboard
  6. close the |Personalizar el Dashboard| modal
  7. click Mostrar Brave News on the new'tab page
  8. Brave news feed displayed as expected (i.e. First article was from ABC News)
  9. close the browser
  10. Upgrade to 1.46.109
  11. launch Brave
  12. click Personalizar>>Brave news
  13. Popular section shows Spain region specific sources EL PAIS, Diarioi AS
  14. closed the modal
  15. scroll thru the feed
  16. confirmed US articles replaced by Spain region's Spanish news articles from ABC News
  17. open NTP and open brave://flags
  18. confirmed #brave'news'v2 set as default in brave://flags
step 1 step 3 step 5 step 7 step 8 step 10 step 13 step 16 step 18
image image image image image image image image image

Case 2: New User - PASSED

  1. Installed 1.46.109
  2. open new-tab page
  3. click on Activar las Noticias sobre Brave to opt-in to Brave news
  4. scroll thru the Brave news feed
  5. Spanish region specific article displayed on the first card i.e. from 20 minutes
  6. clicked on Personalize
  7. Popular section shows region specific sources i.e. EL PAIS, Diario AS
  8. open NTP and open brave://flags
  9. confirmed #brave'news'v2 shows as default in brave://flags
  10. click follow on El Mundo
  11. confirmed article from El Mundo displayed upon refresh
step 1 step 3 step 5 step 7 step 9 step 10 step 11
image image image image image image image

Test Case 2: Region: es_MX - PASSED

Pre-requisite:

  • Set OS language - Espanol (Mexico)
  • Set region: Mexico

Case 1: Existing User - PASSED

  1. Install 1.46.99
  2. launch Brave
  3. clicked on Personalizar on new'tab page
  4. clicked Brave News
  5. Enabled Brave news in the Panel personalizado
  6. close the Panel personalizado| modal
  7. clicked Mostrar Brave News
  8. Brave news feed displayed as expected (i.e. First article was from New York Times)
  9. close the browser
  10. Upgrade to 1.46.109
  11. launch Brave
  12. click Personalizar>>Brave news
  13. Popular section shows region specific sources EL PAÍS Edición América, Xataka
  14. closed both modals
  15. scroll thru the feed
  16. Brave News was enabled in NTP as expected
  17. confirmed US articles replaced by Mexico region's Spanish news articles Milenio
  18. open NTP and opened brave://flags
  19. confirmed #brave'news'v2 set as default in brave://flags
step 1 step 3 step 5 step 7 step 8 step 10 step 13 step 17 step 19
image image image image image image image image image

Case 2: New User - PASSED

  1. Installed 1.46.109
  2. open new-tab page
  3. click on Activar las Noticias sobre Brave to opt-in to Brave news
  4. scroll thru the Brave news feed
  5. Mexico region specific article displayed on the first card i.e. from Milenio
  6. clicked on Personalize
  7. Popular section shows region specific sources i.e. |EL PAÍS Edición América|Xataka
  8. clicked X to close the dialog
  9. clicked on the first news article Imperante .....
  10. Article rendered on the same tab
  11. clicked back arrow to return to news feed
  12. clicked on Personalize
  13. confirmed Brave news dialog displayed Milenio source in Sugerencias as expected
  14. open NTP and open brave://flags
  15. confirmed #brave'news'v2 set as default in brave://flags
step 1 step 3 step 5 step 7 step 10 step 13 step 15
image image image image image image image

Test Case 3: Region: pt_BR - PASSED

Pre-requisite:

  • Set OS language - Português(Brasil)
  • Set region: Brasil
OS region
image image

Case 1: Existing user/Upgrade - PASSED

  1. Install 1.46.99
  2. launch Brave
  3. clicked on Personalizar on the new-tab page
  4. clicked Brave News
  5. Enabled Mostrar Brave News in the Personalizar painel
  6. closed (X) the dialog
  7. clicked Mostrar Brave News on the new'tab page to opt-in to the Brave News
  8. Brave news feed displayed as expected (i.e. First article was from Daily Mail)
  9. closed the browser
  10. upgraded to 1.46.109
  11. launched Brave
  12. clicked Personalizar>>Brave news
  13. confirmed new Brave UI with Popular section shows region specific sources
  14. Brave News was enabled in new-tab page
  15. closed the modal
  16. scroll thru the feed
  17. confirmed US articles replaced by Brasil region's Português news articles - i.e CNN Brasil & VOL
  18. open new-tab page and visit brave://flags
  19. confirmed #brave'news'v2 shows as default in `brave://flags
step 1 step 3 step 5 step 7 step 8 step 10 step 13 step 17 step 19
image image image image image image image image image

Case 2: New user/Fresh Install - PASSED

  1. Installed 1.46.109
  2. launch Brave
  3. open new-tab page
  4. click on Activar Noticias Brave to opt-in to Brave news
  5. scroll thru the Brave news feed
  6. confirmed Brazil region specific article displayed on the first card i.e. from Terra
  7. clicked on Personalize
  8. confirmed Popular section shows region specific sources i.e. UOL, Canaltech
  9. open NTP and open brave://flags
  10. confirmed #brave'news'v2 flag shows as default in brave://flags
  11. click follow on Canaltech
  12. confirmed article from Canaltech loaded
step 3 step6 step8 step10 step12
image image image image image

Test Case 4: Enabled and disabled Brave News from NTP

Pre requisite:

- Set OS language - Espanol (Espana) - Set region: Spain image

Existing user/Upgrade- PASSED

  1. Install 1.46.99
  2. launch Brave
  3. clicked on Personalizar
  4. clicked Brave News
  5. Enabled Mostrar Brave News in the Personalizar el Dashboard
  6. close the Personalizar el Dashboard modal
  7. clicked Mostrar Brave News on the new-tab page
  8. Brave news feed displayed as expected (i.e. articles from Forbes)
  9. open new-tab page
  10. clicked on Personalizar
  11. clicked Brave News
  12. toggle OFF Mostrar Brave News on the new-tab page
  13. close the browser
  14. upgraded to 1.46.109
  15. launched Brave
  16. clicked Personalizar>>Brave news
  17. confirmed new Brave UI is rendered with Brave News toggled ºOFFº
  18. clicked Activar Noticias de Braveº button to turn on Brave News
  19. confirmed Brave News dialog shown Spanish region´s sources
  20. returned to Brave news feed on the new-tab page
  21. confirmed Spain region specific articles shown
step 1 step 4 step 8 step 12 step 14 step 17 step 19 step 21
image image image image image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 18, 2022
@rebron rebron changed the title Brave News: Add additional locales to "Default Enabled" list Add Brazil, Mexico, and Spain to Brave News "Default Enabled" list Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants