Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat value is shown for Solana NFT but not for Ethereum NFT #26684

Closed
srirambv opened this issue Nov 11, 2022 · 2 comments · Fixed by brave/brave-core#15903
Closed

Fiat value is shown for Solana NFT but not for Ethereum NFT #26684

srirambv opened this issue Nov 11, 2022 · 2 comments · Fixed by brave/brave-core#15903

Comments

@srirambv
Copy link
Contributor

Description

Fiat value is shown for Solana NFT but not for Ethereum NFT

Steps to Reproduce

  1. Add both Solana NFT and Ethereum NFT
  2. Click the account that holds the NFT's
  3. Solana NFT shows value in Fiat but Ethereum NFT shows 0

Actual result:

Solana NFT Ethereum NFT
image image

Expected result:

Not sure if it should show the fiat value of the NFT or not

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.47.63 Chromium: 107.0.5304.110 (Official Build) nightly (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Windows 11 Version 22H2 (Build 22623.891)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @yrliou @muliswilliam

@srirambv
Copy link
Contributor Author

Fixed by brave/brave-core@e7f0be6

@srirambv srirambv added this to the 1.46.x - Beta milestone Nov 16, 2022
@srirambv
Copy link
Contributor Author

Verified as part of #26797 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants