Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Welcome JS webpack bundle #26851

Closed
petemill opened this issue Nov 18, 2022 · 1 comment · Fixed by brave/brave-core#16164
Closed

Optimize Welcome JS webpack bundle #26851

petemill opened this issue Nov 18, 2022 · 1 comment · Fixed by brave/brave-core#16164
Assignees
@nullhook
Labels
OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.47.x - Release

Comments

@petemill
Copy link
Member 

❯ ROOT_GEN_DIR=$PWD/../out/Component_arm64/gen DEPFILE_PATH=$TMPDIR\d TARGET_GEN_DIR=$TMPDIR DEPFILE_SOURCE_NAME=wtf webpack --config components/webpack/webpack.config.js --progress --colors --json --mode=production welcome_test=$(pwd)/components/brave_welcome_ui/brave_welcome.tsx > $TMPDIR/stats.json

❯ npx webpack-bundle-analyzer $TMPDIR/stats.json
@nullhook
Copy link

ROOT_GEN_DIR=$PWD/../out/Component_arm64/gen DEPFILE_PATH=$TMPDIR\d TARGET_GEN_DIR=$TMPDIR DEPFILE_SOURCE_NAME=wtf node_modules/.bin/webpack --config components/webpack/webpack.config.js --progress --colors --json --mode=production welcome_test=$(pwd)/components/brave_welcome_ui/brave_welcome.tsx > ~/tmp/stats.json

@nullhook nullhook mentioned this issue Nov 30, 2022
Merged
25 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 2, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 9, 2022
@rebron rebron mentioned this issue Dec 9, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Dec 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Optimized the new Welcome UI and style fixes brave/brave-core
4 participants
@petemill @rebron @nullhook @brave-builds