Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove link subscription option #26906

Closed
deeppandya opened this issue Nov 21, 2022 · 2 comments · Fixed by brave/brave-core#16044
Closed

Remove link subscription option #26906

deeppandya opened this issue Nov 21, 2022 · 2 comments · Fixed by brave/brave-core#16044
Assignees
@deeppandya
Labels
feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.47.x - Release

Comments

@deeppandya
Copy link

This issue is the follow up issue of #21972 to remove link subscription option if user doesn't have active subscription.
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/vpn labels Nov 21, 2022
@deeppandya deeppandya self-assigned this Nov 21, 2022
@deeppandya deeppandya mentioned this issue Nov 21, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 22, 2022
@brave-builds brave-builds mentioned this issue Nov 22, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

We'll need to wait for a 1.47.x RC on the release channel before we can QA the above due to the limitation of not being able to run through VPN on beta.

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following version(s):

Brave	1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit) 
Revision	e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS	Android 12; Build/SP1A.210812.016
  • Ensured that BraveVPNLinkSubscriptionAndroidUIStudy is Enabled under brave://version
  • Ensured that Link Subscription option is not shown when user is not subscribed to VPN
  • Ensured Link Purchase to your Brave Account is shown when user has an active subscription
  • Ensured Link Purchase to your Brave Account is removed after subscription expiration date elapses and user attempts to enable VPN again.
Example Example Example Example Example Example
screenshot-1672959749424 screenshot-1672960084916 screenshot-1672960094053 screenshot-1672960223118 screenshot-1672954472292 screenshot-1672960525923

This was referenced Jan 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Remove link subscription if not active subscription brave/brave-core
4 participants
@kjozwiak @deeppandya @Uni-verse @brave-builds