Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add custom token on desktop #27043

Closed
Douglashdaniel opened this issue Nov 29, 2022 · 2 comments · Fixed by brave/brave-core#16142
Closed

Unable to add custom token on desktop #27043

Douglashdaniel opened this issue Nov 29, 2022 · 2 comments · Fixed by brave/brave-core#16142
Assignees
Labels

Comments

@Douglashdaniel
Copy link

Description

When attempting to add a custom token, clicking the Add button does nothing and throws an error in the console.

Screen Shot 2022-11-29 at 1 25 35 PM

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards? Yes
  • Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include regression feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 29, 2022
@Douglashdaniel Douglashdaniel self-assigned this Nov 29, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 29, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 29, 2022
Repository owner moved this from In Review to Done in Web3 Nov 29, 2022
@kjozwiak
Copy link
Member

The above requires 1.46.133 or higher for 1.46.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Dec 1, 2022

Verification passed on

Brave 1.46.133 Chromium: 108.0.5359.71 (Official Build) (64-bit)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS Linux
  • Verified steps from brave/brave-core#16142
  • Verified able to add custom token
  • Verified no console errors when adding a custom token
27043.mp4

Verification passed on

Brave 1.46.133 Chromium: 108.0.5359.71 (Official Build) (64-bit)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16142
  • Verified able to add custom token
  • Verified no console errors when adding a custom token
27043.mp4

Verification passed on

Brave 1.46.133 Chromium: 108.0.5359.71 (Official Build) (arm64)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16142
  • Verified able to add custom token
  • Verified no console errors when adding a custom token
27043.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants