Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network selector drop down filter on "Edit visible assets" dialog #27093

Closed
Tracked by #29552
Pavneet-Sing opened this issue Dec 1, 2022 · 1 comment · Fixed by brave/brave-core#19015
Closed
Tracked by #29552

Add network selector drop down filter on "Edit visible assets" dialog #27093

Pavneet-Sing opened this issue Dec 1, 2022 · 1 comment · Fixed by brave/brave-core#19015
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Add network selector drop down filter on "Edit visible assets" dialog and show corresponding assets per network

Screenshot from 2022-12-01 22-18-19
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 1, 2022
@Pavneet-Sing Pavneet-Sing added this to Web3 Dec 1, 2022
@HEagle18 HEagle18 moved this to Backlog in Web3 Dec 2, 2022
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 2, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 31, 2023
@Pavneet-Sing Pavneet-Sing moved this from Backlog to In Progress in Web3 Apr 4, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 6, 2023
Closed
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 23, 2023
Merged
25 tasks
@simoarpe simoarpe moved this from In Progress to In Review in Web3 Jun 23, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 26, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 26, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified steps from brave/brave-core#19015
  • Verified network selector is shown in Edit visible asset screen
  • Verified network selector is shown on both portfolio edit visible asset and NFT selector
27093.mp4

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Network filter in edit visible brave/brave-core
4 participants
@Pavneet-Sing @HEagle18 @srirambv @brave-builds