Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to view and manage individual cookies stored per-website in brave://settings #27150

Closed
ShivanKaul opened this issue Dec 3, 2022 · 14 comments · Fixed by brave/brave-core#17746

Comments

@ShivanKaul
Copy link
Collaborator

Description

You can't see individual cookies in brave://settings/cookies any more on Nightly. This must be a Chromium change, I see the same behaviour on Chrome Stable.

Steps to Reproduce

  1. Go to brave://settings/cookies
  2. There is no See all cookies and site data
  3. Click on See all site data and permissions instead
  4. You're redirected to brave://settings/content/all, but clicking on any website in that list sends you to something like brave://settings/content/siteDetails?site=https%3A%2F%2Fgithub.com%2F, where you can modify permissions but can't see local stored data in detail.

Actual result:

image

Expected result:

image

and then clicking on Twitter gives you

image

Reproduces how often:

Easily

Brave version (brave://version info)

Nightly only 1.48.5 Chromium: 108.0.5359.48 (Official Build) nightly (arm64)

@ShivanKaul
Copy link
Collaborator Author

ShivanKaul commented Dec 3, 2022

This is a UX consideration, but ideally we would bring back brave://settings/cookies/detail?site=xyz.com page which could be navigated to from the brave://settings/content/siteDetails?site=xyz.com page.

@ShivanKaul ShivanKaul added the priority/P4 Planned work. We expect to get to it "soon". label Dec 3, 2022
@ShivanKaul
Copy link
Collaborator Author

cc @rebron @mkarolin

@diracdeltas
Copy link
Member

as a side note, if this is the menu referred to in #12375, the trash icon in that never worked at all.

@diracdeltas
Copy link
Member

NVM, the menu in #12375 seems to still be there and broken

@ShivanKaul
Copy link
Collaborator Author

@bridiver pointed out that you can also see cookies for the current site by clicking the lock icon in the left-hand side of the omnibox and selecting Cookies
image

@kbulgrien
Copy link

Another potential workaround uses Developer Mode albeit a bad UX for non-developers:

Hamburger Menu

Extensions

Developer Mode

To access cookies for a particular domain:

Browse to the domain

Ctrl-Shift-I

Network Tab (if not immediately visible, under >>)

Storage

Cookies

From there, right-clicking on a particular cookie offers a delete option and various inspection options also exist.

@kbulgrien
Copy link

This is a UX consideration, but ideally we would bring back brave://settings/cookies/detail?site=xyz.com page which could be navigated to from the brave://settings/content/siteDetails?site=xyz.com page.

IMO, this is more than a UX issue. It seems also a privacy regression in that it makes a user's stored private information more difficult to access and review. It should be possible to easily review what a site stores about visits to facilitate making changes to the way one interacts with a site.

@NipLars
Copy link

NipLars commented Jan 3, 2023

Agree - inspection of cookie detail is unfortunate that it's gone as they are stored in brave.
No need to visit a site again first.

Now you only see that it's 6 cookies, and ability to delete all.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/settings QA/Yes release-notes/include and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 7, 2023
@spylogsster spylogsster self-assigned this Mar 15, 2023
@spylogsster
Copy link

Adding an item to this page

image

@ShivanKaul
Copy link
Collaborator Author

@spylogsster thanks! can you show a screenshot of what page you get when you click on the Cookies and Site Data item?

@spylogsster
Copy link

image

cc @ShivanKaul

@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 10, 2023
@rebron rebron changed the title No way to see individual cookies stored per-website in brave://settings Add ability to see individual cookies stored per-website in brave://settings Apr 26, 2023
@rebron rebron changed the title Add ability to see individual cookies stored per-website in brave://settings Add ability to view and manage individual cookies stored per-website in brave://settings Apr 26, 2023
@stephendonner
Copy link

stephendonner commented May 8, 2023

Verification PASSED using

Brave 1.52.91 Chromium: 113.0.5672.77 (Official Build) beta (x86_64)
Revision c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS macOS Version 11.7.6 (Build 20G1231)

Case 1: View and manage individual cookies - PASSED

Steps:

  1. installed 1.52.91
  2. launched Brave
  3. logged in to github.com
  4. clicked around a bit
  5. loaded brave://settings/cookies
  6. clicked on See all site data and permissions
  7. clicked on github.com on brave://settings/content/all
  8. clicked on Cookies and Site Data on brave://settings/content/siteDetails?site=https%3A%2F%2Fgithub.com%2F
  9. clicked on the down arrow to the right of github.com
  10. clicked on an entry for www.github.com.com
  11. confirmed individual cookie data and ability to Remove via X at brave://settings/cookies/detail?site=github.com
  12. also confirmed Remove All
step 5-6 step 7 step 8 step 9 step 10 step 12
Screen Shot 2023-05-08 at 2 27 51 PM Screen Shot 2023-05-08 at 2 41 02 PM Screen Shot 2023-05-08 at 2 41 07 PM Screen Shot 2023-05-08 at 2 51 59 PM Screen Shot 2023-05-08 at 2 41 18 PM Screen Shot 2023-05-08 at 2 59 08 PM

Case 2: brave://settings/content/all - PASSED

Steps:

  1. installed 1.52.91
  2. launched Brave
  3. loaded cnn.com
  4. clicked around a bit
  5. loaded brave://settings/cookies
  6. clicked on See all site data and permissions
  7. clicked on cnn.com on brave://settings/content/all
  8. clicked on the down arrow to the right of cnn.com
  9. confirmed I could remove all cookies for a single domain via the Trash icon / Remove www.cnn.com icon
  10. confirmed I could remove all cookies associated with a website (NOT a single domain)
  11. confirmed I could remove all data via the Clear all data button
brave://settings/content/all cnn.com cookies individual delete top-level delete Clear all data cleared data
Screen Shot 2023-05-08 at 3 35 36 PM Screen Shot 2023-05-08 at 3 42 28 PM Screen Shot 2023-05-08 at 3 42 32 PM Screen Shot 2023-05-08 at 3 42 45 PM Screen Shot 2023-05-08 at 3 42 52 PM Screen Shot 2023-05-08 at 3 42 56 PM

Case 3: Upgrade - PASSED

Steps:

  1. installed 1.51.110
  2. launched Brave
  3. loaded a bunch of websites
  4. disabled Shields for a selection of websites (and ensured they got added to Sites that can always use cookies)
  5. added a few sites to Sites that can never use cookies
  6. upgraded to 1.52.91

Confirmed:

  • Sites that can always use cookies and Sites that can never use cookies were populated correctly on brave://settings/cookies
  • sites were listed in brave://settings/content/all
  • Cookies and site data link on brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F
  • Cache Storage, Database Storage, Local Storage, and Service Workers were present, with values, on brave://settings/cookies/detail?site=www.youtube.com
  • cookies and their values were present on brave://settings/cookies/detail?site=youtube.com

1.51.110

b...s/cookies b...s/content/all b...s/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F b...s/cookies/detail?site=youtube.com b...s/cookies/detail?site=www.youtube.com
Screenshot 2023-05-08 at 5 22 46 PM Screenshot 2023-05-08 at 5 23 00 PM Screenshot 2023-05-08 at 5 23 26 PM N/A N/A

1.52.91

b...s/cookies b...s/content/all b...s/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F b...s/cookies/detail?site=youtube.com b...s/cookies/details?site=www.youtube.com
Screenshot 2023-05-08 at 5 31 17 PM Screenshot 2023-05-08 at 5 31 22 PM Screenshot 2023-05-08 at 5 31 34 PM Screenshot 2023-05-08 at 5 31 39 PM Screenshot 2023-05-08 at 5 31 55 PM

Logged:

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue regression QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 8, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 11, 2023

Verification PASSED using

Brave | 1.52.94 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Case 1: View and manage individual cookies - PASSED

  1. Install 1.52.94
  2. launched Brave
  3. navigated to coupled sites (github.com and gmail.com)
  4. clicked around a bit
  5. loaded brave://settings/cookies
  6. clicked on See all site data and permissions
  7. clicked on github.com on brave://settings/content/all
  8. clicked on Cookies and Site Data on brave://settings/content/siteDetails?site=https%3A%2F%2Fgithub.com%2F
  9. clicked on the down arrow to the right of github.com
  10. clicked on on the first entry (__Host-user_session_same_site)
  11. confirmed individual cookie data and ability to Remove via X at brave://settings/cookies/detail?site=github.com
  12. also confirmed Remove All
step 5 - 6 step 7 step 8 step 9 -10 step 11 step 12
image image image image image image

Case 2: brave://settings/content/all - PASSED

Steps:

  1. new profile
  2. visited bbc.com
  3. loaded brave://settings/cookies
  4. clicked on See all site data and permissions
  5. clicked on bbc.com on brave://settings/content/all
  6. clicked on bbc.com arrow to view all the cookies
  7. confirmed I could remove all cookies for a single domain via the Trash icon / Remove www.bbc.com icon
  8. confirmed I could remove all cookies associated with a website (NOT a single domain)
  9. confirmed I could remove all data via the Clear all data button
step 4 step 5 step 6 individual delete top-level delete Clear all data cleared data
image image image image image image image

Case 3: Upgrade - PASSED

  1. installed 1.51.114
  2. launched Brave
  3. visited few websites (bbc.com, cnn.com, abcnews.com, nytimes.com, target.com)
  4. disabled Shields for a selection of websites i.e. cnn.com (and ensured they got added to Sites that can always use cookies)
  5. added a few sites to Sites that can never use cookies (target.com)
  6. verified sites are listed in `brave://settings/content/all
  7. upgraded to 1.52.92

Confirmed:

  • Sites that can always use cookies and Sites that can never use cookies were populated correctly on brave://settings/cookies
  • sites were listed in brave://settings/content/all
  • Cookies and site data link on brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F
  • Cache Storage, Database Storage, Local Storage, and Service Workers were present, with values, on brave://settings/cookies/detail?site=www.youtube.com
  • cookies and their values were present on brave://settings/cookies/detail?site=youtube.com

1.51.x

step 1 step 4 -5 step 6
image image image

1.52.x

ex ex ex ex ex
image image image image image

encountered: * #30208

@stephendonner
Copy link

stephendonner commented May 23, 2023

Verification PASSED using

Brave 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit) 
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Linux

Case 1: View and manage individual cookies - PASSED

Steps:

  1. installed 1.52.109
  2. launched Brave
  3. logged in to github.com
  4. clicked around a bit
  5. loaded brave://settings/cookies
  6. clicked on See all site data and permissions
  7. clicked on github.com on brave://settings/content/all
  8. clicked on Cookies and Site Data on brave://settings/content/siteDetails?site=https%3A%2F%2Fgithub.com%2F
  9. clicked on the down arrow to the right of github.com
  10. clicked on an entry for www.github.com.com
  11. confirmed individual cookie data and ability to Remove via X at brave://settings/cookies/detail?site=github.com
  12. also confirmed Remove All
step 5-6 step 7 step 8 step 9 step 10 step 12
Screen Shot 2023-05-23 at 3 23 36 PM Screen Shot 2023-05-23 at 3 19 27 PM Screen Shot 2023-05-23 at 3 19 34 PM Screen Shot 2023-05-23 at 3 21 31 PM Screen Shot 2023-05-23 at 3 21 40 PM Screen Shot 2023-05-23 at 3 22 02 PM

Case 2: brave://settings/content/all - PASSED

Steps:

  1. installed 1.52.109
  2. launched Brave
  3. loaded cnn.com
  4. clicked around a bit
  5. loaded brave://settings/cookies
  6. clicked on See all site data and permissions
  7. clicked on cnn.com on brave://settings/content/all
  8. clicked on the down arrow to the right of cnn.com
  9. confirmed I could remove all cookies for a single domain via the Trash icon / Remove www.cnn.com icon
  10. confirmed I could remove all cookies associated with a website (NOT a single domain)
  11. confirmed I could remove all data via the Clear all data button
brave://settings/content/all cnn.com cookies individual delete top-level delete Clear all data cleared data
Screen Shot 2023-05-23 at 3 28 40 PM Screen Shot 2023-05-23 at 3 28 46 PM Screen Shot 2023-05-23 at 3 28 56 PM Screen Shot 2023-05-23 at 3 29 08 PM Screen Shot 2023-05-23 at 3 29 17 PM Screen Shot 2023-05-23 at 3 29 29 PM

Case 3: Upgrade - PASSED

Steps:

  1. installed 1.51.114
  2. launched Brave
  3. loaded a bunch of websites
  4. disabled Shields for a selection of websites (and ensured they got added to Sites that can always use cookies)
  5. added a few sites to Sites that can never use cookies
  6. upgraded to 1.52.109

Confirmed:

  • Sites that can always use cookies and Sites that can never use cookies were populated correctly on brave://settings/cookies
  • sites were listed in brave://settings/content/all
  • Cookies and site data link on brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F
  • Cache Storage, Database Storage, Local Storage, and Service Workers were present, with values, on brave://settings/cookies/detail?site=www.youtube.com
  • cookies and their values were present on brave://settings/cookies/detail?site=youtube.com

1.51.114

b...s/cookies b...s/content/all b...s/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F b...s/cookies/detail?site=youtube.com b...s/cookies/detail?site=www.youtube.com
Screen Shot 2023-05-23 at 3 43 37 PM Screen Shot 2023-05-23 at 3 43 59 PM Screen Shot 2023-05-23 at 3 44 36 PM

1.52.109

b...s/cookies b...s/content/all b...s/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F b...s/cookies/detail?site=youtube.com b...s/cookies/details?site=www.youtube.com
Screen Shot 2023-05-23 at 3 48 22 PM Screen Shot 2023-05-23 at 3 48 49 PM Screen Shot 2023-05-23 at 3 56 32 PM Screen Shot 2023-05-23 at 3 50 04 PM Screen Shot 2023-05-23 at 3 50 23 PM

Logged:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment