Brave Ads clicked events should not trigger if there is no corresponding viewed event for the ad placement

[tmancey]

Description

Brave Ads clicked events should not trigger if there is no corresponding viewed event for the placement id

Steps to Reproduce

1. Join Rewards
2. View a new tab page sponsored image ad (do not close this tab as it is required in step 6)
3. Reset Brave Rewards
4. Join Rewards
5. Wait for tokens to refill
6. Click the new tab page sponsored image ad (from step 3)

Actual result:

User is rewarded

Expected result:

User should not be rewarded because the ad was viewed with a previous wallet

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[btlechowski]

Verification passed on

Brave	1.49.91 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#16712

inline ad

Ad was served:

[4596:4596:0216/180441.416830:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[4596:4596:0216/180441.424528:VERBOSE1:eligible_inline_content_ads_v1.cc(211)] Get eligible ads for untargeted segment
[4596:4596:0216/180441.444876:VERBOSE2:priority.h(35)] 1 ads with a priority of 1 in bucket 1
[4596:4596:0216/180441.446874:VERBOSE1:eligible_inline_content_ads_v1.cc(244)] 1 eligible ads out of 1 ads for untargeted segment
[4596:4596:0216/180441.447415:VERBOSE1:inline_content_ad.cc(67)] Opportunity arose to serve an inline content ad
[4596:4596:0216/180441.448091:VERBOSE1:inline_content_ad_serving.cc(98)] Found 1 eligible ads
[4596:4596:0216/180441.448683:VERBOSE1:inline_content_ad_serving.cc(133)] Served inline content ad:
  placementId: 84c33ada-d9be-4bd6-b676-b81d785eb69b
  creativeInstanceId: e4958d00-e35c-4134-a408-1fbcf274d5ae
  creativeSetId: 8b848823-c47f-43de-a753-2efa8dea6863
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Staging - Inline Test 1
  description: Fung Brave News Inline Display Ad - mac/linux
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: Work at Brave
  targetUrl: https://brave.com/careers
[4596:4596:0216/180441.468190:VERBOSE3:inline_content_ad_event_served.cc(19)] Served inline content ad with placement id 84c33ada-d9be-4bd6-b676-b81d785eb69b and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[4596:4596:0216/180441.502743:VERBOSE1:inline_content_ad_event_served.cc(28)] Successfully logged inline content ad served event

Ad was clicked without view. Verified click event is not triggered:

[4596:4596:0216/180931.410130:VERBOSE1:inline_content_ad_event_handler.cc(156)] Inline content ad: Not allowed as debounced kClicked event for placement id 84c33ada-d9be-4bd6-b676-b81d785eb69b
[4596:4596:0216/180931.410965:VERBOSE1:inline_content_ad_event_handler.cc(176)] Failed to fire inline content ad kClicked event for placement id 84c33ada-d9be-4bd6-b676-b81d785eb69b and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae

ntp si ad

Steps:

1. Clean profile
2. Trigger NTPSI (keep the tap open)
3. Enable rewards and ads
4. Wait for unblinded tokens refill
5. Click the NTP SI ad

[11299:11299:0228/230550.886097:VERBOSE1:new_tab_page_ad_event_handler.cc(158)] New tab page ad: Not allowed because an ad was not served for placement id ec38a5c3-3978-4a3f-a6fb-7a9de4c11198
[11299:11299:0228/230550.888435:VERBOSE1:new_tab_page_ad_event_handler.cc(186)] Failed to fire new tab page ad kClicked event for placement id ec38a5c3-3978-4a3f-a6fb-7a9de4c11198 and creative instance id ef2ac6fc-7d91-4fef-acdf-f34c1a514443