Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special URLs for top YouTubers not compatible with Brave #2732

Closed
kirkins opened this issue Dec 24, 2018 · 3 comments
Closed

Special URLs for top YouTubers not compatible with Brave #2732

kirkins opened this issue Dec 24, 2018 · 3 comments
Labels
closed/duplicate Issue has already been reported closed/invalid feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue.

Comments

@kirkins
Copy link

kirkins commented Dec 24, 2018

Description

Most users have a url in this pattern:

https://youtube.com/user/

or

https://youtube.com/channel/

Bart Baker, Philip De Franco, and other top YouTubers have a special URL without a prefix

https://youtube.com/BartBaker

https://www.youtube.com/PhilipDeFranco

In addition to the normal url pattern.

As this url is an edge case it is not supported by Brave. Brave instead associates https://youtube.com/BartBaker with the YouTube website itself.

Steps to Reproduce

  1. Go to https://youtube.com/BartBaker
  2. Open tip banner
  3. See it is associated with YouTube and not Bart Baker

Actual result:

Expected result:

Tip Bart Baker instead of YouTube.

Reproduces how often:

Always

Brave version (brave://version info)

0.58.17 Chromium: 71.0.3578.98 (Official Build) unknown (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

No

Additional Information

@kirkins kirkins changed the title Special URLs for top YouTubers not compatible with Brave banner Special URLs for top YouTubers not compatible with Brave Dec 24, 2018
@jnki
Copy link

jnki commented Dec 24, 2018

seems it's not just for top youtubers
I'm a nobody and my youtube url is in that format too.
https://www.youtube.com/jenoki
same issue happens of course

@srirambv
Copy link
Contributor

@kirkins can you verify this on 0.58.18? Also you might need to wait till the verified pubs list is downloaded. There would be some latency between the time you enable rewards and open the tip panel.

@srirambv srirambv added feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 25, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 25, 2018
@NejcZdovc
Copy link
Contributor

closing as dupe of #1886

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Dec 27, 2018
@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Dec 27, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue.
Projects
None yet
Development

No branches or pull requests

5 participants