Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update makes 2 downloads every time #27398

Closed
Clorr opened this issue Dec 15, 2022 · 6 comments · Fixed by brave/brave-core#16555
Closed

Update makes 2 downloads every time #27398

Clorr opened this issue Dec 15, 2022 · 6 comments · Fixed by brave/brave-core#16555
Assignees
@mherrmann
Labels
OS/Desktop OS/macOS QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@Clorr
Copy link

Clorr commented Dec 15, 2022

Description

Every time there is an update to Brave Browser, I have 2 downloads : A first small download, and a big that is around 130MB
It looks like a failed incremental update, but maybe it's not. In that case don't take this in account.

Steps to Reproduce

  1. When an update is available, click on the update button

Actual result:

One small download starts and complete, then a second download, of around 130MB, starts also

Expected result:

Why 2 downloads ? Is the first download a delta and the second a full ?
Only one, hopefully delta (small) update should happen

Reproduces how often:

Every time since I installed Brave (more than one year ago)

Brave version (brave://version info)

1.46.144 Chromium: 108.0.5359.128 (Build officiel) (x86_64)
macOS Version 10.15.7 (assemblage 19H2026)

Version/Channel Information:

Révision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
@diracdeltas
Copy link
Member

@mherrmann

@mherrmann
Copy link

Thank you for reporting this @Clorr. Your suspicion is correct. I can reproduce this on macOS 10.15.7, updating Brave 1.46.140 -> 1.146.144. This should be a pure delta update (20 MB in this case). But the update mechanism downloads first the delta and then the full 135 MB installer. (This can be inspected with Fiddler Everywhere, for example.)

@mherrmann mherrmann self-assigned this Dec 21, 2022
@mherrmann mherrmann mentioned this issue Jan 6, 2023
Merged
16 tasks
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 6, 2023
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 22, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Mar 6, 2023 •
edited
Loading

Verified with macOS x64 12.6.3 using various versions.

See https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1677031515215569 for additional discussion/details.

General note - when installing via .pkg, may still get the sparkle update popups UI where you need to allow the download/install of new version. See #9562.

For all failed cases below, the update still occurs, it just falls back to full installer. See #28915 for additional information.

Delta Installer - 2 PASSED, 2 FAILED

Note, for all cases below 1.50.77 was the current public beta build (meaning, available on the update server). 1.49.108 was the previous public beta build (meaning, the last beta version that was available on the update server prior to 1.50.77). When going from one public build to the next, the delta should be served.

All cases below check background updates.

Case 1 - x64 (.dmg) --> x64 - PASSED

Objective: Confirm delta installer used to update from x64 1.49.108 --> x64 1.50.77, use .dmg file for initial download

  1. Install 1.49.108 (x64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[71402:259:0306/111907.915323:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[71402:259:0306/111907.916288:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[71402:259:0306/111907.996040:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[71402:259:0306/111918.809253:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 2 - x64 (.pkg) --> x64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm delta installer used to update from x64 1.49.108 --> x64 1.50.77, use .pkg file for initial download

  1. Install 1.49.108 (x64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[72151:259:0306/143458.089985:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[72151:259:0306/143458.090926:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[72151:259:0306/143541.471893:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[72151:259:0306/143628.557568:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 3 - universal (.dmg) --> x64 - FAILED, follow up issue logged

Objective: Confirm delta installer used to update from universal 1.49.108 --> x64 1.50.77, use .dmg file for initial download

  1. Install 1.49.108 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[73152:259:0306/182458.700200:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[73152:259:0306/182458.701103:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[73152:259:0306/182458.701616:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[73152:259:0306/182500.914763:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[73152:259:0306/182529.216810:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[73152:259:0306/182628.033198:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 4 - universal (.pkg) --> x64 - FAILED, follow up issue logged (note, Sparkle popups received in this case)

Objective: Confirm delta installer used to update from universal 1.49.108 --> x64 1.50.77, use .pkg file for initial download

  1. Install 1.49.108 (universal .pkg version, not x64), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[1214:259:0306/125717.259057:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1214:259:0306/125717.259894:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1214:259:0306/125746.394392:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1214:259:0306/125748.941831:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Full Installer - 4 PASSED

Note, for all cases below, 1.49.116 was never a public version (meaning, it was never on the update server). Going from a non-public build to public build, full installer should be served, not delta.

All cases below check background updates.

Case 1 - x64 (.dmg) --> x64 - PASSED

Objective: Confirm full installer used to update from x64 1.49.116 --> x64 1.50.77, use .dmg file for initial download

  1. Install 1.49.116 (x64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[994:259:0306/141451.912683:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[994:259:0306/141451.913397:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[994:259:0306/141451.913772:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[994:259:0306/141520.752868:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 2 - x64 (.pkg) --> x64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm full installer used to update from x64 1.49.116 --> x64 1.50.77, use .pkg file for initial download

  1. Install 1.49.116 (x64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[1838:259:0306/174650.109191:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1838:259:0306/174650.110621:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1838:259:0306/174702.237013:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1838:259:0306/174740.093343:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 3 - universal (.dmg) --> x64 - PASSED

Objective: Confirm full installer used to update from universal 1.49.116 --> x64 1.50.77, use .dmg file for initial download

  1. Install 1.49.116 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
4 6 8

Logs from step 7:

[1048:259:0306/150857.911366:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1048:259:0306/150857.912220:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1048:259:0306/150857.912662:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1048:259:0306/150927.674441:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 4 - universal (.pkg) --> x64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm full installer used to update from x64 1.49.116 --> x64 1.50.77, use .pkg file for initial download

  1. Install 1.49.116 (universal .pkg version, not x64), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[1750:259:0306/181839.706997:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1750:259:0306/181839.708707:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[1750:259:0306/181849.179880:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Update on `test` channel - 1 PASSED, 1 FAILED

All cases below check background updates.

Current release channel version is 1.48.171, a version without the fix.
test channel currently has 1.49.118, a version with the fix.

Objective: Confirm can update from a version without the fix to a version with the fix.

Case 1 - x64 (.dmg) --> x64 - PASSED
  1. Install 1.48.171 (x64 .dmg version, not universal), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[952:259:0306/153327.330293:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[952:259:0306/153327.332005:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[952:259:0306/153327.333774:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[952:259:0306/153327.401932:WARNING:CONSOLE(182)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data_deprecated.js (182)
[952:259:0306/153339.530355:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.
Case 2 - universal (.dmg) --> x64 - FAILED, follow up issue logged
  1. Install 1.48.171 (universal .dmg version, not x64), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[1624:259:0306/184345.333331:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1624:259:0306/184345.334535:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[1624:259:0306/184345.335521:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[1624:259:0306/184347.430888:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[1624:259:0306/184415.473606:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
On demand updates - 1 PASSED, 1 FAILED

In below cases, checking the on demand updates/update check via brave://settings/help.

Case 1 - x64 (.dmg) --> x64 - PASSED

Confirm delta installer used to update from x64 1.48.171 --> x64 1.49.118, use .dmg file for initial download

  1. Install 1.48.171 (x64 .dmg version, not universal), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
Step 4 Step 6 Step 8
4 6 8

Logs from step 7:

[2373:259:0306/131923.913580:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[2373:259:0306/131923.914517:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[2373:259:0306/131923.915223:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[2373:259:0306/131935.590561:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
Case 2 - universal (.dmg) --> x64 - FAILED, follow up issue logged

Confirm delta installer used to update from universal 1.48.171 --> x64 1.49.118, use .dmg file for initial download

  1. Install 1.48.171 (universal .dmg version, not x64), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
Step 4 Step 6 Step 8
4 6 8

Logs from step 7:

[3050:259:0306/133424.027549:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[3050:259:0306/133424.029046:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[3050:259:0306/133424.030243:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[3050:259:0306/133426.106903:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[3050:259:0306/133455.324207:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 6, 2023
@LaurenWags LaurenWags mentioned this issue Mar 6, 2023
Open
@LaurenWags
Copy link
Member

LaurenWags commented Mar 6, 2023 •
edited
Loading

Verified with macOS arm64 12.6.3 using various versions.

See https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1677031515215569 for additional discussion/details.

General note - when installing via .pkg, may still get the sparkle update popups UI where you need to allow the download/install of new version. See #9562.

For all failed cases below, the update still occurs, it just falls back to full installer. See #28915 for additional information.

Delta Installer - 2 PASSED, 2 FAILED

Note, for all cases below 1.50.77 was the current public beta build (meaning, available on the update server). 1.50.76 was the previous public beta build (meaning, the last beta version that was available on the update server prior to 1.50.77). When going from one public build to the next, the delta should be served.

All cases below check background updates.

Case 1 - arm64 (.dmg) --> arm64 - PASSED

Objective: Confirm delta installer used to update from arm64 1.50.76 --> arm64 1.50.77, use .dmg file for initial download

  1. Install 1.50.76 (arm64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[3816:259:0306/202758.446146:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[3816:259:0306/202758.447522:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[3816:259:0306/202758.448135:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[3816:259:0306/202801.723817:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Case 2 - arm64 (.pkg) --> arm64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm delta installer used to update from arm64 1.50.76 --> arm64 1.50.77, use .pkg file for initial download

  1. Install 1.50.76 (arm64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[1074:259:0306/173935.503230:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1074:259:0306/173935.504113:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1074:259:0306/173955.250962:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Case 3 - universal (.dmg) --> arm64 - FAILED, follow up issue logged

Objective: Confirm delta installer used to update from universal 1.50.76 --> arm64 1.50.77, use .dmg file for initial download

  1. Install 1.50.76 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[1594:259:0306/204902.882220:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1594:259:0306/204902.883601:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1594:259:0306/204902.884230:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1594:259:0306/204903.900915:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1594:259:0306/204925.639354:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Case 4 - universal (.pkg) --> arm64 - FAILED, follow up issue logged (note, Sparkle popups received in this case)

Objective: Confirm delta installer used to update from universal 1.50.76 --> arm64 1.50.77, use .pkg file for initial download

  1. Install 1.50.76 (universal .pkg version, not arm64), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[2186:259:0307/000120.701670:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[2186:259:0307/000120.702339:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[2186:259:0307/000128.305081:WARNING:CONSOLE(161)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data_deprecated.js (161)
[2186:259:0307/000142.248722:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[2186:259:0307/000143.575793:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[2186:259:0307/000234.744908:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Full Installer - 4 PASSED

Note, for all cases below, 1.49.116 was never a public version (meaning, it was never on the update server). Going from a non-public build to public build, full installer should be served, not delta.

All cases below check background updates.

Case 1 - arm64 (.dmg) --> arm64 - PASSED

Objective: Confirm full installer used to update from arm64 1.49.116 --> arm64 1.50.77, use .dmg file for initial download

  1. Install 1.49.116 (arm64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[1210:259:0306/182315.114613:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1210:259:0306/182315.115309:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1210:259:0306/182315.115605:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1210:259:0306/182336.859031:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Case 2 - arm64 (.pkg) --> arm64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm full installer used to update from arm64 1.49.116 --> arm64 1.50.77, use .pkg file for initial download

  1. Install 1.49.116 (arm64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[1726:259:0306/213023.847113:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1726:259:0306/213023.847778:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[1726:259:0306/213038.630423:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Case 3 - universal (.dmg) --> arm64 - PASSED

Objective: Confirm full installer used to update from universal 1.49.116 --> arm64 1.50.77, use .dmg file for initial download

  1. Install 1.49.116 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[2266:259:0307/003815.459678:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[2266:259:0307/003815.461039:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[2266:259:0307/003815.462098:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[2266:259:0307/003837.524399:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Case 4 - universal (.pkg) --> arm64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm full installer used to update from arm64 1.49.116 --> x64 1.50.77, use .pkg file for initial download

  1. Install 1.49.116 (universal .pkg version, not arm64), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
4a 4b 6 8

Logs from step 7:

[2833:259:0307/160643.967500:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[2833:259:0307/160643.968839:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
[2833:259:0307/160656.810361:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:11:11 +0000, Version: 1.50.77.0)
Update on `test` channel - 1 PASSED, 1 FAILED

All cases below check background updates.

Current release channel version is 1.48.171, a version without the fix.
test channel currently has 1.49.118, a version with the fix.

Objective: Confirm can update from a version without the fix to a version with the fix.

Case 1 - arm64 (.dmg) --> arm64 - PASSED
  1. Install 1.48.171 (arm64 .dmg version, not universal), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[1466:259:0306/191728.760772:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1466:259:0306/191728.762631:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[1466:259:0306/191728.763210:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[1466:259:0306/191736.991994:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
Case 2 - universal (.dmg) --> arm64 - FAILED, follow up issue logged
  1. Install 1.48.171 (universal .dmg version, not arm64), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
1 6 8

Logs from step 7:

[1954:259:0306/222304.574997:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[1954:259:0306/222304.576602:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[1954:259:0306/222304.577446:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[1954:259:0306/222307.161149:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[1954:259:0306/222330.387072:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
On demand updates - 1 PASSED, 1 FAILED

In below cases, checking the on demand updates/update check via brave://settings/help.

Case 1 - arm64 (.dmg) --> arm64 - PASSED

Confirm delta installer used to update from arm64 1.48.171 --> arm64 1.49.118, use .dmg file for initial download

  1. Install 1.48.171 (arm64 .dmg version, not universal), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
Step 4 Step 6 Step 8
4 6 8

Logs from step 7:

[2687:259:0306/163206.923447:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[2687:259:0306/163206.925600:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[2687:259:0306/163206.926793:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[2687:259:0306/163214.039293:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
Case 2 - universal (.dmg) --> arm64 - FAILED, follow up issue logged

Confirm delta installer used to update from universal 1.48.171 --> arm64 1.49.118, use .dmg file for initial download

  1. Install 1.48.171 (universal .dmg version, not arm64), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
Step 4 Step 6 Step 8
4 6 8

Logs from step 7:

[3071:259:0306/163531.808023:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[3071:259:0306/163531.810242:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[3071:259:0306/163531.811553:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[3071:259:0306/163534.249686:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[3071:259:0306/163556.718879:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)

@stephendonner
Copy link

stephendonner commented Mar 6, 2023 •
edited
Loading

Verification PASSED using Big Sur 11.7.4, Intel/x86

Delta installer - 2 PASSED, 2 FAILED
Case 1: x64 (.dmg) --> x64 - PASSED

Objective: Confirm delta installer used to update from x64 1.49.108 --> x64 1.50.77, use .dmg file for initial download

  1. Install 1.49.108 (x64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-06 at 12 34 50 PM Screen Shot 2023-03-06 at 3 39 08 PM Screen Shot 2023-03-06 at 3 42 02 PM

Logs from step 7:

[24422:259:0306/154034.130456:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[24422:259:0306/154034.132733:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[24422:259:0306/154034.133479:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[24422:259:0306/154048.550616:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 2: x64 (.pkg) --> x64 - PASSED

Objective: Confirm delta installer used to update from x64 1.49.108 --> x64 1.50.77, use .pkg file for initial download

  1. Install 1.49.108 (x64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
Screen Shot 2023-03-06 at 12 51 28 PM Screen Shot 2023-03-06 at 3 57 07 PM Screen Shot 2023-03-06 at 3 55 04 PM Screen Shot 2023-03-06 at 3 59 33 PM

Logs from step 7:

[25077:259:0306/155615.358519:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[25077:259:0306/155615.360403:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[25077:259:0306/155615.373047:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 3: universal (.dmg) --> x64 - FAILED
  1. Install 1.49.108 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 5 step 8
Screen Shot 2023-03-06 at 7 43 51 PM Screen Shot 2023-03-06 at 10 51 02 PM Screen Shot 2023-03-06 at 10 50 07 PM

Logs from step 7:

[81706:259:0306/224718.632592:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[81706:259:0306/224718.634150:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[81706:259:0306/224718.635960:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[81706:259:0306/224741.183369:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[81706:259:0306/224852.879699:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[81706:259:0306/224916.183603:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 4: universal (.pkg) --> x64 - FAILED
  1. Install 1.49.108 (universal .pkg version, not x64), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-06 at 5 28 24 PM Screen Shot 2023-03-06 at 8 17 42 PM Screen Shot 2023-03-06 at 9 31 40 PM

Logs from step 7:

[43530:259:0306/201308.223681:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[43530:259:0306/201308.225150:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[43530:259:0306/201308.227327:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[43530:259:0306/201417.849866:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[43530:259:0306/201437.559857:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Full installer - 4 PASSED
Case 1: x64 (.dmg) --> x64 - PASSED
  1. Install 1.49.116 (x64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-06 at 6 21 05 PM Screen Shot 2023-03-06 at 6 24 33 PM Screen Shot 2023-03-06 at 6 25 31 PM

Logs:

[36792:259:0306/182350.594733:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[36792:259:0306/182350.596539:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[36792:259:0306/182350.597611:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[36792:259:0306/182450.859462:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[36792:259:0306/182504.648119:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 2: x64 (.pkg) --> x64 - PASSED
  1. Install 1.49.116 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 4 step 8
Screen Shot 2023-03-06 at 6 45 38 PM Screen Shot 2023-03-06 at 6 54 42 PM Screen Shot 2023-03-06 at 6 55 21 PM

Logs:

[38815:259:0306/185317.751407:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[38815:259:0306/185317.752675:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[38815:259:0306/185317.755005:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[38815:259:0306/185413.973673:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[38815:259:0306/185450.918683:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 3: universal (.dmg) --> x64 - PASSED
  1. Install 1.49.116 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-06 at 7 19 10 PM Screen Shot 2023-03-06 at 7 21 32 PM Screen Shot 2023-03-06 at 7 22 44 PM

Logs from step 7:

[40337:259:0306/192107.765029:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[40337:259:0306/192107.767233:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[40337:259:0306/192107.769480:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[40337:259:0306/192209.207752:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
[40337:259:0306/192216.986749:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 17:10:09 +0000, Version: 1.50.77.0)
Case 4: universal (.pkg) --> x64 - PASSED
  1. Install 1.49.116 (universal .pkg version, not dmg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  6. Watch logs and Fiddler
  7. Confirm full update was served successfully (did not attempt delta)
  8. Once logs mention "will install update" this means download is complete, relaunch
  9. Confirm updated version on brave://version
step 1 step 6 step 9
Screen Shot 2023-03-06 at 7 28 55 PM Screen Shot 2023-03-06 at 7 36 53 PM Screen Shot 2023-03-06 at 7 39 04 PM
Update on test channel - 1 PASSED, 1 FAILED
Case 1 - x64 (.dmg) --> x64 - PASSED
  1. Install 1.48.171 (x64 .dmg version, not universal), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-06 at 2 35 23 PM Screen Shot 2023-03-06 at 2 36 46 PM Screen Shot 2023-03-06 at 2 35 35 PM

Logs from step 7:

[29930:259:0306/143347.217121:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[29930:259:0306/143347.222947:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[29930:259:0306/143347.225009:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[29930:259:0306/143409.861844:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[29930:259:0306/143526.370254:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
Case 2 - universal (.dmg) --> x64 - FAILED
  1. Install 1.48.171 (universal .dmg version, not x64), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-06 at 2 53 12 PM Screen Shot 2023-03-06 at 2 54 54 PM Screen Shot 2023-03-06 at 2 55 33 PM

Logs from step 7:

[30426:259:0306/174607.420618:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[30426:259:0306/174642.664201:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[30435:259:0306/174700.331669:ERROR:shared_image_manager.cc(247)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.
[30435:259:0306/174700.331936:ERROR:skia_output_device_buffer_queue.cc(345)] Invalid mailbox.
[30426:259:0306/174700.960038:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
On-demand updates - 1 PASSED, 1 FAILED
Case 1: x64 (.dmg) --> x64 - PASSED
  1. Install 1.48.171 (x64 .dmg version, not universal), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
step 4 step 6 step 8
Screen Shot 2023-03-06 at 1 36 26 PM Screen Shot 2023-03-06 at 1 37 06 PM Screen Shot 2023-03-06 at 1 39 07 PM

Logs from step 7:

[27041:259:0306/133547.136667:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[27041:259:0306/133547.138549:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[27041:259:0306/133547.223744:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[27041:259:0306/133608.947223:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[27041:259:0306/133857.907519:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
Case 2: universal (.dmg) --> x64 - FAILED

Confirm delta installer used to update from universal 1.48.171 --> x64 1.49.118, use .dmg file for initial download

  1. Install 1.48.171 (universal .dmg version, not x64), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
Step 4 Step 6 Step 8
Screen Shot 2023-03-06 at 2 03 03 PM Screen Shot 2023-03-06 at 2 02 19 PM Screen Shot 2023-03-06 at 2 03 29 PM

Logs from step 7:

[28265:259:0306/140140.102003:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[28265:259:0306/140140.103838:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[28265:259:0306/140140.105335:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[28265:259:0306/140151.242682:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[28265:259:0306/140243.230148:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)
[28265:259:0306/140322.055351:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:45:58 +0000, Version: 1.49.118.0)

@stephendonner
Copy link

stephendonner commented Mar 7, 2023 •
edited
Loading

Verification PASSED using Big Sur 11.7.4, M1/arm64

Delta installer - 2 PASSED, 2 FAILED
Case 1 - arm64 (.dmg) --> arm64 - PASSED

Objective: Confirm delta installer used to update from arm64 1.50.78 --> arm64 1.50.83, use .dmg file for initial download

  1. Install 1.50.77 (arm64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
Screen Shot 2023-03-08 at 10 56 02 AM Screen Shot 2023-03-08 at 10 53 15 AM Screen Shot 2023-03-08 at 11 09 30 AM

Logs from step 7:

[3739:259:0308/110706.162041:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[3739:259:0308/110706.163365:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[3739:259:0308/110706.164741:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[3739:259:0308/110712.743810:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Case 2 - arm64 (.pkg) --> arm64 - PASSED (note, Sparkle popups received in this case)

Objective: Confirm delta installer used to update from arm64 1.50.77 --> arm64 1.50.83, use .pkg file for initial download

  1. Install 1.50.77 (arm64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
Screen Shot 2023-03-08 at 2 47 02 PM Screen Shot 2023-03-08 at 2 48 10 PM Screen Shot 2023-03-08 at 2 50 45 PM Screen Shot 2023-03-08 at 2 48 29 PM

Logs from step 7:

[4576:259:0308/111612.860012:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[4576:259:0308/111612.861356:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[4576:259:0308/111612.863046:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[4576:259:0308/111619.999616:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Case 3 - universal (.dmg) --> arm64 - FAILED

Objective: Confirm delta installer used to update from universal 1.50.77 --> arm64 1.50.83, use .dmg file for initial download

  1. Install 1.50.77 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 1 Step 6 Step 8
Screen Shot 2023-03-08 at 3 00 55 PM Screen Shot 2023-03-08 at 3 01 45 PM Screen Shot 2023-03-08 at 3 03 04 PM

Logs from step 7:

[10112:259:0308/150100.922616:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[10112:259:0308/150100.924631:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[10112:259:0308/150100.925741:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[10112:259:0308/150103.392344:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[10112:259:0308/150144.690891:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Case 4 - universal (.pkg) --> arm64 - FAILED (note, Sparkle popups received in this case)

Objective: Confirm delta installer used to update from universal 1.50.77 --> arm64 1.50.83, use .pkg file for initial download

  1. Install 1.50.77 (universal .pkg version, not arm64), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 4 Step 6 Step 8
Screen Shot 2023-03-08 at 6 17 21 PM Screen Shot 2023-03-08 at 6 18 24 PM Screen Shot 2023-03-08 at 6 18 50 PM Screen Shot 2023-03-08 at 6 21 57 PM

Logs from step 7:

[19310:259:0308/181703.618740:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[19310:259:0308/181703.619632:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[19310:259:0308/181725.960482:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[19310:259:0308/181729.082895:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Full installer - 4 PASSED
Case 1: arm64 (.dmg) --> arm64 - PASSED
  1. Install 1.49.116 (arm64 .dmg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-07 at 12 48 57 PM Screen Shot 2023-03-07 at 3 59 02 PM Screen Shot 2023-03-07 at 3 57 28 PM

Logs from step 7:

[23577:259:0307/155514.571945:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[23577:259:0307/155514.576468:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[23577:259:0307/155514.578834:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[23577:259:0307/155609.086633:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[23577:259:0307/155700.166079:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Case 2: arm64 (.pkg) --> arm64 - PENDING
  1. Install 1.49.116 (arm64 .pkg version, not universal), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
    Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
Step 4 Step 6 Step 8
Screenshot 2023-03-08 at 1 15 32 AM

Logs from step 7:

[57330:259:0307/192942.668936:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[57330:259:0307/192942.670629:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[57330:259:0307/192942.671777:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[57330:259:0307/193002.801961:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Case 3: universal (.dmg) --> arm64 - FAILED
  1. Install 1.49.116 (universal .dmg version, not .pkg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Watch logs and Fiddler
  6. Confirm full update was served successfully (did not attempt delta)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-07 at 7 22 28 PM Screen Shot 2023-03-07 at 7 24 06 PM Screen Shot 2023-03-07 at 7 24 44 PM

Logs from step 7:

[56594:259:0307/191031.759954:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[56594:259:0307/191031.760985:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[56594:259:0307/191031.761626:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[56594:259:0307/191113.208228:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[56594:259:0307/191122.804200:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Case 4: universal (`.pkg`) --> arm64 - PASSED
  1. Install 1.49.116 (universal .pkg version, not dmg), close quickly after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr
  5. Step 4a - since using .pkg, note Sparkle popups received, select "Install Update"
  6. Watch logs and Fiddler
  7. Confirm full update was served successfully (did not attempt delta)
  8. Once logs mention "will install update" this means download is complete, relaunch
  9. Confirm updated version on brave://version
step 1 step 6 step 9
Screen Shot 2023-03-07 at 4 00 58 PM Screen Shot 2023-03-07 at 7 11 14 PM Screen Shot 2023-03-07 at 7 11 37 PM

Logs from step 7:

[56594:259:0307/191031.759954:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[56594:259:0307/191031.760985:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[56594:259:0307/191031.761626:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[56594:259:0307/191113.208228:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
[56594:259:0307/191122.804200:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Tue, 07 Mar 2023 09:29:36 +0000, Version: 1.50.83.0)
Update on `test` channel - 1 PASSED, 1 FAILED

Objective: Confirm can update from a version without the fix to a version with the fix.

Case 1 - arm64 (.dmg) --> arm64 - PASSED
  1. Install 1.48.171 (arm64 .dmg version, not universal), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-07 at 6 13 22 PM [Fiddler] Screen Shot 2023-03-07 at 6 14 06 PM

Logs from step 7:

[50554:259:0307/181307.178346:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[50554:259:0307/181307.180455:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[50554:259:0307/181307.181677:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[50554:259:0307/181314.412104:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[50554:259:0307/181346.429127:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
Case 2 - universal (.dmg) --> arm64 - FAILED
  1. Install 1.48.171 (universal .dmg version, not .pkg), close after launching
  2. Close browser, advance system clock ~3hrs
  3. Ensure Fiddler or similar program is running
  4. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version on brave://version
step 1 step 6 step 8
Screen Shot 2023-03-07 at 5 54 52 PM Screen Shot 2023-03-07 at 2 39 20 PM Screen Shot 2023-03-07 at 5 58 31 PM

Logs from step 7:

[49052:259:0307/175331.971686:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[49052:259:0307/175331.972226:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[49052:259:0307/175350.759676:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[49052:259:0307/175446.116641:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[49052:259:0307/175512.544088:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
On-demand updates - 1 PASSED, 1 FAILED
Case 1: arm64 (.dmg) --> arm64 - PASSED
  1. Install 1.48.171 (arm64 .dmg version, not universal), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. Confirm delta update was served successfully (did not fall back to full installer)
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
step 4 step 6 step 8
Screen Shot 2023-03-07 at 2 27 32 PM Screen Shot 2023-03-07 at 2 27 45 PM Screen Shot 2023-03-07 at 2 27 57 PM

Logs from step 7:

[46291:259:0307/142159.397997:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[46291:259:0307/142159.399088:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[46291:259:0307/142159.399662:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[46291:259:0307/142220.000194:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[46291:259:0307/142255.069694:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
Case 2: universal (.dmg) --> arm64 - FAILED

Confirm delta installer used to update from universal 1.48.171 --> arm64 1.49.118, use .dmg file for initial download

  1. Install 1.48.171 (universal .dmg version, not .pkg), close after launching
  2. Ensure Fiddler or similar program is running
  3. Relaunch browser from terminal with --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  4. Visit brave://settings/help
  5. Watch logs and Fiddler
  6. ---> Delta update not served successfully, fell back to full installer (.dmg) - Follow up issue logged when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915
  7. Once logs mention "will install update" this means download is complete, relaunch
  8. Confirm updated version
Step 4 Step 6 Step 8
Screen Shot 2023-03-07 at 2 38 50 PM Screen Shot 2023-03-07 at 2 39 20 PM Screen Shot 2023-03-07 at 2 39 28 PM

Logs from step 7:

[47767:259:0307/143756.737784:INFO:sparkle_glue.mm(366)] brave update: did finish loading appcast
[47767:259:0307/143756.739782:INFO:sparkle_glue.mm(372)] brave update: did find valid update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[47767:259:0307/143756.740954:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[47767:259:0307/143806.306848:INFO:sparkle_glue.mm(393)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[47767:259:0307/143845.174198:INFO:sparkle_glue.mm(429)] brave update: will install update on quit with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)
[47767:259:0307/143853.974695:INFO:sparkle_glue.mm(419)] brave update: will install update with AppcastItem(Date: Fri, 03 Mar 2023 07:58:02 +0000, Version: 1.49.118.0)

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
@stephendonner stephendonner added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherrmann mherrmann

Labels
OS/Desktop OS/macOS QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Fix macOS delta updates brave/brave-core
6 participants
@stephendonner @diracdeltas @Clorr @mherrmann @LaurenWags @brave-builds