If Brave is not set as default upon first launch, brave://settings/getStarted page should show Make default button

[MadhaviSeelam]

Description

When Brave is not set as default in brave://welcome first screen and complete (with or without import) onboarding process, and navigate to brave://settings/getStarted page, Brave is your default browser message shown. It should show Make default button instead. Opened a link from Slack to confirm, it opened to Brave Beta.

Steps to Reproduce

1. new profile
2. launch Brave
3. click Skip on brave://welcome screen
4. click Skip on Import Settings screen
5. click finish
6. new-tab page is shown
7. go to brave://settings/getStarted

Actual result:

Brave://settings/getStarted page shows Brave is your default browser message

Expected result:

Brave://settings/getStarted page should show Make default button

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.47.149 Chromium: 109.0.5414.46 (Official Build) beta (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 22H2 (Build 22621.963)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@spylogsster @rebron

[rebron]

cc: @nullhook

[rebron]

Closing as invalid. Discussed with @MadhaviSeelam

[stephendonner]

Closing as invalid. Discussed with @MadhaviSeelam

@rebron @MadhaviSeelam As this might affect me on macOS for verification, I'd love to know the reasoning, as well. Thanks!

[MadhaviSeelam]

@stephendonner - So the reason being I've already set Brave Beta (for some testing) as a default in the windows settings. These settings are over riding Skip in the UI.

So here are the two scenarios I tested:
Scenario 1:
Pre-requisite: Make sure Microsoft Edge is default browser Or do a Reset in Reset all default all apps (Windows Settings>>Apps>>Default Apps>

• Follow the STR from the description
• Make Default button shown as expected

Scenario 2:
Continue from scenario 1:
- delete the profile
- switched default file types (html, .htm, .svg, http, https) to Beta in Windows Settings>>Apps>>Default Apps>

• Followed STR from the description and this time, I didn't get Make default button.
• Since this is an edge case or not real use case, decided to close.

[stephendonner]

Thanks, I suspected as much but wanted to confirm, as I didn't see any issues with the Make default button, as written, with your tests on macOS when I tested 👍