Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium- based browser shown on Import Settings screen #27557

Closed
MadhaviSeelam opened this issue Dec 28, 2022 · 3 comments · Fixed by brave/brave-core#16800
Closed

Chromium- based browser shown on Import Settings screen #27557

MadhaviSeelam opened this issue Dec 28, 2022 · 3 comments · Fixed by brave/brave-core#16800
Assignees
Labels
bug feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@MadhaviSeelam
Copy link

Description

Steps to Reproduce

Pre-requisite: Brave Nightly and Microsoft Edge browsers are installed

  1. Install 1.47.151
  2. launch Brave
  3. click Set Brave as default browser

Actual result:

Chromium- based browser is checked as default

Expected result:

Along with Edge, Brave Nightly should be listed
image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.47.151 Chromium: 109.0.5414.46 (Official Build) beta (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 22H2 (Build 22621.963)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @nullhook
@kjozwiak
Copy link
Member

The above requires 1.48.151 or higher for 1.48.x verification 👍

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Feb 1, 2023

Verification PASSED using

Brave | 1.48.152 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
-- | --
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Windows 11 Version 21H2 (Build 22000.1455)
  • Install 1.48.152
  • launch Brave
  • click Set Brave as default browser in the brave://welcome screen
  • verify Import Settings page

Confirmed Microsoft Internet explorer is shown with correct icon not selected as default along with other browsers.

image

@LaurenWags
Copy link
Member

Removed QA/Test-All-Platforms label per discussion with @kjozwiak @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants