Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default for BraveEnableAutoTranslate in the code #27577

Closed
atuchin-m opened this issue Dec 30, 2022 · 3 comments · Fixed by brave/brave-core#16483
Closed

Update default for BraveEnableAutoTranslate in the code #27577

atuchin-m opened this issue Dec 30, 2022 · 3 comments · Fixed by brave/brave-core#16483
Assignees
Labels
brave-translate feature/translate OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented Dec 30, 2022

The feature BraveEnableAutoTranslate should be disabled by default (the same as in Griffin).

Griffin issue: brave/brave-variations#480 (The steps to verify can be found here)

STR for QA:

Please take a look brave/brave-core#16483 (comment) for STR/Cases for Desktop & Android.

@atuchin-m atuchin-m self-assigned this Dec 30, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 30, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Jan 3, 2023
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 9, 2023
@kjozwiak
Copy link
Member

The above requires 1.47.171 or higher for 1.47.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 12, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.47.171 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 10 Version 21H2 (Build 19044.2486)

Prerequisite: ensure that you don't relaunch the browser and pull BraveAutoTranslateStudy:AutoTranslateDisabled when verifying the above. Basically need to makes sure that the browser isn't restarted after first launch so it doesn't pull and apply the seed file from Griffin. This way, you know you're QAing the change from b-c.

  • ensured that Always translate [language] isn't visible under the hamburger menu via Brave Translate
  • ensured that Always translate [language] never appears under the languages being detected after translating several sites
  • ensured that Brave Translate appears within the omnibox when it detects a supported locale that it can translate
  • ensured that you can translate several websites without any issues (mostly checked on Wikipedia and tried a few randoms)
  • ensured that the auto translate feature is still disabled once you've restarted the browser and pulled BraveAutoTranslateStudy:AutoTranslateDisabled
Example Example Example Example Example
image image image image image

Traslated few languages successfully:

Example Example Example Example
image image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 12, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 12, 2023

Verified on Samsung Galaxy S21 5G using version:

Brave	1.47.171 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 13; Build/TP1A.220624.014

Using STR/Test Plan in brave/brave-core#16483 (comment)

Prerequisite: ensure that you don't relaunch the browser and pull BraveAutoTranslateStudy:AutoTranslateDisabled when verifying the above. Basically need to makes sure that the browser isn't restarted after first launch so it doesn't pull and apply the seed file from Griffin. This way, you know you're QAing the change from b-c.

  • ensured that Always translate [language] isn't visible under the hamburger menu via Brave Translate
  • ensured that Brave Translate appears at the bottom of the viewport when it detects a supported locale that it can translate
  • ensured that you can translate several websites without any issues (mostly checked on Wikipedia and tried a few randoms)
  • ensured that the auto translate feature is still disabled once you've restarted the browser and pulled BraveAutoTranslateStudy:AutoTranslateDisabled
  • ensured that Use Brave Translate is enabled by default via Settings -> Languages
  • ensured that disabling Use Brave Translate via Settings -> Languages disables Brave Translate
  • ensured that you're not seeing Brave Translate when visiting websites that can be translated
  • ensured that re-enabling works as expected and re-enables the feature without any issues (checked that it's working as well)
Example Example Example Example Example Example
screenshot-1673540393080 screenshot-1673540298113 screenshot-1673540479413 screenshot-1673540621116 screenshot-1673540643927 screenshot-1673540446469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brave-translate feature/translate OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants