Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent casing between panel and page transaction titles #27646

Closed
josheleonard opened this issue Jan 4, 2023 · 1 comment · Fixed by brave/brave-core#16533
Closed

Inconsistent casing between panel and page transaction titles #27646

josheleonard opened this issue Jan 4, 2023 · 1 comment · Fixed by brave/brave-core#16533
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@josheleonard
Copy link

Screenshot 2023-01-03 at 11 32 52 AM

Description

Casing for transaction title text should match between panel & page UIs
@josheleonard josheleonard self-assigned this Jan 4, 2023
@josheleonard josheleonard added this to Web3 Jan 4, 2023
@josheleonard josheleonard added feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 4, 2023
@josheleonard josheleonard mentioned this issue Jan 4, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this to Done in Web3 Jan 5, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 5, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#16533
  • Verified Sent is shown in same casing on both panel and transaction activity page
    image

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16533
  • Verified Sent is shown in same casing on both panel and transaction activity page
    image

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16533
  • Verified Sent is shown in same casing on both panel and transaction activity page
    image

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix: activity page transaction title casing brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds