Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"OK" Button on Token Grant does nothing #2774

Closed
aphelionz opened this issue Jan 1, 2019 · 2 comments
Closed

"OK" Button on Token Grant does nothing #2774

aphelionz opened this issue Jan 1, 2019 · 2 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@aphelionz
Copy link

aphelionz commented Jan 1, 2019

Description

When visiting any site and clicking the Brave "triangle" logo, the token grant and corresponding "OK" button does not respond to clicks.

screenshot_20190101_104155

Steps to Reproduce

  1. Visit any site
  2. Click the brave logo to the right of the address bar
  3. Click the "OK" button under token grant.

Actual result:

  1. Nothing happens, it is unresponsive.

Expected result:

  1. I am taken to the token grant page or to more information

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Have not tried.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? N/A
@aphelionz aphelionz changed the title "OK" "OK" Button on Token Grant does nothing Jan 1, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 1, 2019
@NejcZdovc NejcZdovc added the needs-investigation A bug not 100% confirmed/fixed label Jan 3, 2019
@aphelionz
Copy link
Author

Another interesting thing is that other controls in that same popup seem to be affected as well. For example, I cannot toggle the "Include in Auto-Contribute" slider for GitHub here:

screenshot_20190105_195359

@mandar-brave mandar-brave added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 9, 2019
@NejcZdovc
Copy link
Contributor

closing as dupe of #2883

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 10, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed needs-investigation A bug not 100% confirmed/fixed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 10, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

6 participants