Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on review request dialog #27750

Closed
SergeyZhukovsky opened this issue Jan 11, 2023 · 1 comment · Fixed by brave/brave-core#16702
Closed

Crash on review request dialog #27750

SergeyZhukovsky opened this issue Jan 11, 2023 · 1 comment · Fixed by brave/brave-core#16702
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@SergeyZhukovsky
Copy link
Member

Not sure is it possible to replicate or not. I got it when a dialog to review an app appeared and I clicked on a smile to review it. It happened on Nightly build v1.49.11.

Crash stack is:

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Context.getPackageName()' on a null object reference
        at android.content.ComponentName.<init>(ComponentName.java:132)
        at android.content.Intent.<init>(Intent.java:7432)
        at com.google.android.play.core.review.c.a(c.java:5)
        at org.chromium.chrome.browser.rate.BraveAskPlayStoreRatingDialog.lambda$rating$3(BraveAskPlayStoreRatingDialog.java:109)
        at com.google.android.play.core.tasks.a.run(a.java:0)
        at android.os.Handler.handleCallback(Handler.java:942)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7872)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2023

As discussed, the above will be checked/verified via #25777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants