Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Bottomsheet in rewards page and show ui in rewards panel when no notification permission #27795

Closed
sujitacharya2005 opened this issue Jan 13, 2023 · 3 comments · Fixed by brave/brave-core#17002
Assignees
Labels
Android 13 Impacting Android 13 devices feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@sujitacharya2005
Copy link

Description

Show below when there is no notification permission related to rewards

  1. Brave Rewards page show a bottomsheet dialog
  2. Rewards panel show the UI

image

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@sujitacharya2005 sujitacharya2005 added QA/Yes OS/Android Fixes related to Android browser functionality Android 13 Impacting Android 13 devices labels Jan 13, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 13, 2023

Can we change the text to "Enable notifications to earn BAT".

Also, how does this interact with the new non-connected 2.5 panel?

cc: @deeppandya @sujitacharya2005

@kjozwiak
Copy link
Member

@deeppandya so looks like the above was never implemented. I think this is what you were showing be in our call when I was mentioning that I wasn't seeing any warnings re: notifications being disabled within brave://rewards or the rewards panel. Unless there's some other UI/UX that I might have missed. When implementing the above, please keep in mind both #27851 & #27852 re: making sure that the warning appears when users have only disabled All "Brave Ads" notifications.

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 29, 2023

Verified on Samsung GS 21 5G using version

Brave	1.50.108 Chromium: 112.0.5615.39 (Official Build) (64-bit) 
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Android 13; Build/TP1A.220624.014
  • Ensured 'no notification permission' notifications are shown in brave://rewards and brave rewards panel when they're disabled.
Example Example Example
screenshot-1680105262883 screenshot-1680105273299 screenshot-1680105736935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 13 Impacting Android 13 devices feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants